Files
react-native-devtools-frontend/front_end/source_frame/ImageView.js
T
Tim van der Lippe 6ec121d8c3 Fix URL flickering in image preview pane
https://chromium-review.googlesource.com/c/chromium/src/+/1633989 introduced
a regression where the alt text was visible for a short period of time,
until the actual image would be loaded.

This hapened, because the alt text was set in the constructor, whereas
the image itself is loaded in `_updateContentIfNeeded`. Since the browser
shows the alt text when there is no src (or the image hasn't finished loading
yet), this would flicker.

To remedy the situation, set the alt text after the src to make sure we do
have the image loaded before we also update the alt text.

R=petermarshall@chromium.org

Bug: chromium:1066415
Change-Id: I1391919560e503edddf6f7621a14d6d9a2281d95
Fixed: 1114617
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2381418
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
2020-08-28 12:49:29 +00:00

200 lines
7.2 KiB
JavaScript
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
/*
* Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
* 3. Neither the name of Apple Computer, Inc. ("Apple") nor the names of
* its contributors may be used to endorse or promote products derived
* from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
* EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
* WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
* DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
// @ts-nocheck
// TODO(crbug.com/1011811): Enable TypeScript compiler checks
import * as Common from '../common/common.js';
import * as Host from '../host/host.js';
import * as Platform from '../platform/platform.js';
import * as TextUtils from '../text_utils/text_utils.js';
import * as UI from '../ui/ui.js';
import * as Workspace from '../workspace/workspace.js';
/**
* @unrestricted
*/
export class ImageView extends UI.View.SimpleView {
/**
* @param {string} mimeType
* @param {!TextUtils.ContentProvider.ContentProvider} contentProvider
*/
constructor(mimeType, contentProvider) {
super(Common.UIString.UIString('Image'));
this.registerRequiredCSS('source_frame/imageView.css');
this.element.tabIndex = -1;
this.element.classList.add('image-view');
this._url = contentProvider.contentURL();
this._parsedURL = new Common.ParsedURL.ParsedURL(this._url);
this._mimeType = mimeType;
this._contentProvider = contentProvider;
this._uiSourceCode = contentProvider instanceof Workspace.UISourceCode.UISourceCode ?
/** @type {!Workspace.UISourceCode.UISourceCode} */ (contentProvider) :
null;
if (this._uiSourceCode) {
this._uiSourceCode.addEventListener(
Workspace.UISourceCode.Events.WorkingCopyCommitted, this._workingCopyCommitted, this);
new UI.DropTarget.DropTarget(
this.element, [UI.DropTarget.Type.ImageFile, UI.DropTarget.Type.URI],
Common.UIString.UIString('Drop image file here'), this._handleDrop.bind(this));
}
this._sizeLabel = new UI.Toolbar.ToolbarText();
this._dimensionsLabel = new UI.Toolbar.ToolbarText();
this._mimeTypeLabel = new UI.Toolbar.ToolbarText(mimeType);
this._container = this.element.createChild('div', 'image');
this._imagePreviewElement = this._container.createChild('img', 'resource-image-view');
this._imagePreviewElement.addEventListener('contextmenu', this._contextMenu.bind(this), true);
}
/**
* @override
* @return {!Promise<!Array<!UI.Toolbar.ToolbarItem>>}
*/
async toolbarItems() {
return [
this._sizeLabel, new UI.Toolbar.ToolbarSeparator(), this._dimensionsLabel, new UI.Toolbar.ToolbarSeparator(),
this._mimeTypeLabel
];
}
/**
* @override
*/
wasShown() {
this._updateContentIfNeeded();
}
/**
* @override
*/
disposeView() {
if (this._uiSourceCode) {
this._uiSourceCode.removeEventListener(
Workspace.UISourceCode.Events.WorkingCopyCommitted, this._workingCopyCommitted, this);
}
}
_workingCopyCommitted() {
this._updateContentIfNeeded();
}
async _updateContentIfNeeded() {
const {content} = await this._contentProvider.requestContent();
if (this._cachedContent === content) {
return;
}
const contentEncoded = await this._contentProvider.contentEncoded();
this._cachedContent = content;
let imageSrc = TextUtils.ContentProvider.contentAsDataURL(content, this._mimeType, contentEncoded);
if (content === null) {
imageSrc = this._url;
}
const loadPromise = new Promise(x => {
this._imagePreviewElement.onload = x;
});
this._imagePreviewElement.src = imageSrc;
this._imagePreviewElement.alt = ls`Image from ${this._url}`;
const size = content && !contentEncoded ? content.length : base64ToSize(content);
this._sizeLabel.setText(Platform.NumberUtilities.bytesToString(size));
await loadPromise;
this._dimensionsLabel.setText(Common.UIString.UIString(
'%d × %d', this._imagePreviewElement.naturalWidth, this._imagePreviewElement.naturalHeight));
}
_contextMenu(event) {
const contextMenu = new UI.ContextMenu.ContextMenu(event);
if (!this._parsedURL.isDataURL()) {
contextMenu.clipboardSection().appendItem(
Common.UIString.UIString('Copy image URL'), this._copyImageURL.bind(this));
}
if (this._imagePreviewElement.src) {
contextMenu.clipboardSection().appendItem(
Common.UIString.UIString('Copy image as data URI'), this._copyImageAsDataURL.bind(this));
}
contextMenu.clipboardSection().appendItem(
Common.UIString.UIString('Open image in new tab'), this._openInNewTab.bind(this));
contextMenu.clipboardSection().appendItem(Common.UIString.UIString('Save…'), this._saveImage.bind(this));
contextMenu.show();
}
_copyImageAsDataURL() {
Host.InspectorFrontendHost.InspectorFrontendHostInstance.copyText(this._imagePreviewElement.src);
}
_copyImageURL() {
Host.InspectorFrontendHost.InspectorFrontendHostInstance.copyText(this._url);
}
_saveImage() {
const link = createElement('a');
link.download = this._parsedURL.displayName;
link.href = this._url;
link.click();
}
_openInNewTab() {
Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(this._url);
}
/**
* @param {!DataTransfer} dataTransfer
*/
async _handleDrop(dataTransfer) {
const items = dataTransfer.items;
if (!items.length || items[0].kind !== 'file') {
return;
}
const entry = items[0].webkitGetAsEntry();
const encoded = !entry.name.endsWith('.svg');
entry.file(file => {
const reader = new FileReader();
reader.onloadend = () => {
let result;
try {
result = /** @type {?string} */ (reader.result);
} catch (e) {
result = null;
console.error('Can\'t read file: ' + e);
}
if (typeof result !== 'string') {
return;
}
this._uiSourceCode.setContent(encoded ? btoa(result) : result, encoded);
};
if (encoded) {
reader.readAsBinaryString(file);
} else {
reader.readAsText(file);
}
});
}
}