mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-11-01 18:59:10 +08:00

Files

T

Tim van der Lippe fdbd42e2f8 Add eslint-import-plugin to node_modules

Will be used to make sure no default exports are in DevTools.

The PRESUBMIT.py has been updated to skip running the formatting check
if node_modules files are affected, to workaround crbug.com/1068198.

DISABLE_THIRD_PARTY_CHECK=Add plugin to node_modules

Bug: 1068198
Change-Id: I04d4dc813daa01099f21d40edf47aaefcc0b045f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2135610
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>

2020-04-07 14:27:34 +00:00

1.8 KiB

Raw Blame History

Release steps

create a release-[x.y.z] branch from tip of master (or whatever release commit)
```
git checkout master && git pull && git checkout -b release-2.1.0
```
bump package.json + update CHANGELOG version links for all releasing packages (i.e., root + any resolvers)

In changelog for core plugin, normally leave [Unreleased] but update its link at the bottom to be rooted at the new version's tag, and add a link for the new version rooted at last version's tag.
```
[Unreleased]: https://github.com/benmosher/eslint-plugin-import/compare/v2.0.1...HEAD
[2.0.1]: https://github.com/benmosher/eslint-plugin-import/compare/v2.0.0...v2.0.1
```
becomes
```
[Unreleased]: https://github.com/benmosher/eslint-plugin-import/compare/v2.1.0...HEAD
[2.1.0]: https://github.com/benmosher/eslint-plugin-import/compare/v2.0.1...v2.1.0
[2.0.1]: https://github.com/benmosher/eslint-plugin-import/compare/v2.0.0...v2.0.1
```
Generally, don't use npm version for this because it creates a tag, which I normally wait until signoff from contributors and actually npm publish-ing to snap the tag.
create pull request from release-[x.y.z] into release branch

I like this because it
- lists all commits in the release
- provides a commentary location to discuss the release
- builds in CI and provides test results
iterate on feedback
- handle other issues
- merge more PRs
- fix issues in changelog/docs
npm publish from release-[x.y.z] branch
- don't forget resolvers!
tag commit (v[x.y.z])
- again, not forgetting resolvers, if needed (resolvers/[name]/v[t.u.v])
merge release-[x.y.z] into release (
- ideally fast-forward, probably with Git CLI instead of Github
merge release into master

Done!

1.8 KiB Raw Blame History

Release steps

1.8 KiB

Raw Blame History