Tim van der Lippe
96de606848
Throughout this process we learned the following: - The magically generated agents need to be properly exposed on the target, rather than setting them on the TargetBase prototype. - We need to rename the protocol proxy api definitions to use the invoke_ naming, such that we can use structured request bodies. This will allow us to no longer rely on parameter ordering and does not require additional changes to the underlying Closure generated code. - Instead of using a symbol as an index on a different class, use a WeakMap to keep track of the link between the NetworkRequest and the NetworkManager. This breaks the circular dependency and allows us to remove the lookup with the symbol R=aerotwist@chromium.org,jacktfranklin@chromium.org Bug: 1011811 Change-Id: I6cf25533b32793636d970b0a6c108f739d4e757e Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2167868 Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by: Paul Lewis <aerotwist@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
DevTools Scripts
Development workflow scripts
These are scripts that can be useful to run independently as you're working on Chrome DevTools front-end.
The newer scripts such as for testing and hosted mode are written in Node.js, which has become the standard toolchain for web apps. The older scripts such as building (e.g. bundling and minifying) are written in Python, which has first-class support in Chromium's infrastructure.
Overview
Folders
- build - Python package for generating DevTools debug and release mode
- chrome_debug_launcher - automagically finds Chrome Canary and launches it with debugging flags (e.g. remote debugging port)
- closure - see section on Closure Compiler below
- gulp - experimental build process written in node.js & gulp to remove the dependency on Chromium-specific build tools (i.e. gn and ninja)
- hosted_mode - run DevTools on a localhost development server
- jsdoc_validator - enforces the use of Closure type annotations
Python Scripts
- compile_frontend.py - runs closure compiler to do static type analysis
- Note: the compiled outputs are not actually used to run DevTools
- lint_javascript.py - run eslint
- optimize_svg_images.py - manually run when changing svg images
Node.js scripts
The easiest way to run the node.js scripts is to use npm run which displays all the commands. For more information on the specific npm run commands, take a look at the primary devtools front-end readme (../readme.md).
Closure
DevTools manually rolls the closure compiler to ./closure. If you manually roll closure compiler, you will need to re-generate the closure_runner (in ./closure) and jsdoc_validator custom jars using the python scripts in their respective directory.