Jack Franklin
6aa02364f0
This CL fixes a number of bugs that we discovered in the bridges generation. Some come as a result of breaking AST changes in TypeScript 4, and others are a result of using TS features in the components code that we haven't used before and therefore the generator code needs updating accordingly. The list of changes are: * Dealing with `Readonly<X>` and `ReadonlyArray<X>`, discarding the wrapper type and parsing the inner type. * An update to the null checking code as TS4.0 changed how `null` literals are represented in the AST. * Update the generator tree walker to avoid trying to parse `import * as ...`. * Error nicely if we detect an interface being referenced as `Foo.Bar`. We only support referencing interfaces directly. Change-Id: I2faf314d28281863b2ad9e1695cde8ff60014ead Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2284825 Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
DevTools Scripts
Development workflow scripts
These are scripts that can be useful to run independently as you're working on Chrome DevTools front-end.
The newer scripts such as for testing and hosted mode are written in Node.js, which has become the standard toolchain for web apps. The older scripts such as building (e.g. bundling and minifying) are written in Python, which has first-class support in Chromium's infrastructure.
Overview
Folders
- build - Python package for generating DevTools debug and release mode
- chrome_debug_launcher - automagically finds Chrome Canary and launches it with debugging flags (e.g. remote debugging port)
- closure - see section on Closure Compiler below
- gulp - experimental build process written in node.js & gulp to remove the dependency on Chromium-specific build tools (i.e. gn and ninja)
- hosted_mode - run DevTools on a localhost development server
- jsdoc_validator - enforces the use of Closure type annotations
Python Scripts
- compile_frontend.py - runs closure compiler to do static type analysis
- Note: the compiled outputs are not actually used to run DevTools
- lint_javascript.py - run eslint
- optimize_svg_images.py - manually run when changing svg images
Node.js scripts
The easiest way to run the node.js scripts is to use npm run which displays all the commands. For more information on the specific npm run commands, take a look at the primary devtools front-end readme (../readme.md).
Closure
DevTools manually rolls the closure compiler to ./closure. If you manually roll closure compiler, you will need to re-generate the closure_runner (in ./closure) and jsdoc_validator custom jars using the python scripts in their respective directory.