mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-11 06:04:55 +08:00
Tim van der Lippe
501473c8d1
Previously, we were gating the `skipLibCheck` on `is_debug=true`. However, this introduced the problem where CQ runs would fail on compilation, but local runs succeeding. This confused developers and required handling a different GN output directory with the GN flag `is_debug=false`. But, we don't want to lose the performance benefit related to not unnecessarily checking all `.d.ts` files all the time. So we have to find a middleground. The solution is to add 1 `ts_library` target in `front_end` which essentially verifies that the `.d.ts` are all in good order. This means we only do the check once, irrespective the number of `ts_library` targets in the frontend. DISABLE_THIRD_PARTY_CHECK=TypeScript fix R=jacktfranklin@chromium.org CC=sigurds@chromium.org Bug: 1011811 Change-Id: Ide2d3a5935fdc34dc79572d65c9e5ce92d78a9a8 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2209090 Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>