mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-07 04:26:32 +08:00
Mandy Chen
ac715f012b
Manually wrap localizable strings in localization calls and remove the
presubmit check that issues an error when the 3rd argument to
createInput() is not localized.
Presubmit output before:
DevTools localization checker detected errors!
third_party\blink\renderer\devtools\front_end\devices\DevicesView.js Line 379: third argument to createInput() should be localized: editor.createInput('port', 'text', 'Device port (3333)', portValidator.bind(this))
third_party\blink\renderer\devtools\front_end\devices\DevicesView.js Line 382: third argument to createInput() should be localized: editor.createInput('address', 'text', 'Local address (dev.example.corp:3333)', addressValidator)
third_party\blink\renderer\devtools\front_end\network\NetworkManageCustomHeadersView.js Line 136: third argument to createInput() should be localized: editor.createInput('header', 'text', 'x-custom-header', validateHeader.bind(this))
third_party\blink\renderer\devtools\front_end\node_main\NodeConnectionsPanel.js Line 166: third argument to createInput() should be localized: editor.createInput('address', 'text', 'Network address (e.g. localhost:9229)', addressValidator)
third_party\blink\renderer\devtools\front_end\persistence\EditFileSystemView.js Line 159: third argument to createInput() should be localized: editor.createInput('pathPrefix', 'text', '/path/to/folder/', pathPrefixValidator.bind(this))
third_party\blink\renderer\devtools\front_end\settings\FrameworkBlackboxSettingsTab.js Line 137: third argument to createInput() should be localized: editor.createInput('pattern', 'text', '/framework\\.js$', patternValidator.bind(this))
After:
DevTools localization checker passed
Bug: 965674
Change-Id: Ie3d8f0b20283c0997d00e42bd8341af22c10b32f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623461
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Cr-Original-Commit-Position: refs/heads/master@{#662299}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b855f4a2b3f306bb3b9e5e2797ac49adfe5438aa
DevTools Scripts
Development workflow scripts
These are scripts that can be useful to run independently as you're working on Chrome DevTools front-end.
The newer scripts such as for testing and hosted mode are written in Node.js, which has become the standard toolchain for web apps. The older scripts such as building (e.g. bundling and minifying) are written in Python, which has first-class support in Chromium's infrastructure.
Overview
Folders
- build - Python package for generating DevTools debug and release mode
- chrome_debug_launcher - automagically finds Chrome Canary and launches it with debugging flags (e.g. remote debugging port)
- closure - see section on Closure Compiler below
- gulp - experimental build process written in node.js & gulp to remove the dependency on Chromium-specific build tools (i.e. gn and ninja)
- hosted_mode - run DevTools on a localhost development server
- jsdoc_validator - enforces the use of Closure type annotations
- local_node - installs a local runtime of node.js
Python Scripts
- convert_svg_images_to_png.py - manually run when adding svg images
- compile_frontend.py - runs closure compiler to do static type analysis
- Note: the compiled outputs are not actually used to run DevTools
- lint_javascript.py - run eslint
- optimize_png_images.py - manually run when adding png images
Node.js scripts
The easiest way to run the node.js scripts is to use npm run which displays all the commands. For more information on the specific npm run commands, take a look at the primary devtools front-end readme (../readme.md).
Closure
DevTools manually rolls the closure compiler to ./closure. If you manually roll closure compiler, you will need to re-generate the closure_runner (in ./closure) and jsdoc_validator custom jars using the python scripts in their respective directory.