Tim van der Lippe
b3b90761b1
This checks in the InspectorBackendCommands in the source tree file and ensures that it is kept in sync whenever the third_party location has been updated. In the process, I discovered multiple misconfigurations in the formatting presubmit check. First of all, it was never running, because the .eslintignore had an empty line. Second of all, it was running twice, which is unnecessary since we now check for changed files at the end of the presubmit. Lastly, it was only formatting JS files, while it should check all files. I have also updated the _CheckGeneratedFiles check to only run if it is actually necessary. If there are no changes made to any affected of the files, it will skip the step. This should thus reduce the presubmit time and we will only pay the cost if we actually update any of the files. Lastly, it will now properly format and lint the generated files. This makes reading the code a lot easier and makes it easier to digest the diff when a protocol update goes through. I have verified that, in a full build, the files are still minified. Thus, this has no impact on the loading performance. DISABLE_THIRD_PARTY_CHECK=Updating protocol generation Fixed: 1056614 Change-Id: If49b0e749978ea1a7838992ec13507ee761ad76c Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2087765 Reviewed-by: Paul Lewis <aerotwist@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
DevTools Scripts
Development workflow scripts
These are scripts that can be useful to run independently as you're working on Chrome DevTools front-end.
The newer scripts such as for testing and hosted mode are written in Node.js, which has become the standard toolchain for web apps. The older scripts such as building (e.g. bundling and minifying) are written in Python, which has first-class support in Chromium's infrastructure.
Overview
Folders
- build - Python package for generating DevTools debug and release mode
- chrome_debug_launcher - automagically finds Chrome Canary and launches it with debugging flags (e.g. remote debugging port)
- closure - see section on Closure Compiler below
- gulp - experimental build process written in node.js & gulp to remove the dependency on Chromium-specific build tools (i.e. gn and ninja)
- hosted_mode - run DevTools on a localhost development server
- jsdoc_validator - enforces the use of Closure type annotations
Python Scripts
- compile_frontend.py - runs closure compiler to do static type analysis
- Note: the compiled outputs are not actually used to run DevTools
- lint_javascript.py - run eslint
- optimize_svg_images.py - manually run when changing svg images
Node.js scripts
The easiest way to run the node.js scripts is to use npm run which displays all the commands. For more information on the specific npm run commands, take a look at the primary devtools front-end readme (../readme.md).
Closure
DevTools manually rolls the closure compiler to ./closure. If you manually roll closure compiler, you will need to re-generate the closure_runner (in ./closure) and jsdoc_validator custom jars using the python scripts in their respective directory.