mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-09-30 17:27:22 +08:00
Christy Chen
5d7848d54d
This reverts commit9e5ab71e50. Reason for revert: The Cl was reverted due to devtools pak file limitation. That issue has been fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2558341 Original change's description: > Revert "[Loc] Migrate changes tool to localization V2" > > This reverts commitabcb8f7aa8. > > Reason for revert: Consistently causing autoroll issues when rolling devtools-frontend into Chromium - see https://chromium-review.googlesource.com/c/chromium/src/+/2554521 for an example. > > To recreate this, do a debug build of Chromium with this patch applied to DevTools. It's causing an issue with duplicate keys in the pak files. No DevTools Frontend builds do a debug build of Chromium with the DevTools frontend patch applied so our CQ will be green despite causing an issue. > > You can run this locally in Chromium to reproduce via: > > autoninja -C out/Default chrome:packed_resources_extra > > Which will show the error. > > Original change's description: > > [Loc] Migrate changes tool to localization V2 > > > > Migrate changes tool > > Tested with en-XL: https://imgur.com/a/hFDBjQV > > > > > > Bug: 1136655 > > Change-Id: Ic434c3085b9e2f2cf44583cca7ee1ce8f1d412f2 > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2548688 > > Commit-Queue: Christy Chen <chrche@microsoft.com> > > Reviewed-by: Simon Zünd <szuend@chromium.org> > > TBR=szuend@chromium.org,chrche@microsoft.com > > Change-Id: I94b27434562f6a6bff3be381ab8a5802bd8b03f9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1136655 > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2557044 > Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> TBR=szuend@chromium.org,chrche@microsoft.com,jacktfranklin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1136655 Change-Id: I35166a6f4f38462073b933c01c169b3c8d14311b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567344 Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Christy Chen <chrche@microsoft.com> Commit-Queue: Christy Chen <chrche@microsoft.com>
38 lines
727 B
JSON
38 lines
727 B
JSON
{
|
|
"extensions": [
|
|
{
|
|
"type": "view",
|
|
"location": "drawer-view",
|
|
"id": "changes.changes",
|
|
"title": "Changes",
|
|
"persistence": "closeable",
|
|
"className": "Changes.ChangesView"
|
|
},
|
|
{
|
|
"type": "@Common.Revealer",
|
|
"contextTypes": [
|
|
"WorkspaceDiff.DiffUILocation"
|
|
],
|
|
"destination": "Changes drawer",
|
|
"className": "Changes.ChangesView.DiffUILocationRevealer"
|
|
}
|
|
],
|
|
"dependencies": [
|
|
"workspace_diff",
|
|
"text_editor",
|
|
"workspace",
|
|
"diff",
|
|
"i18n",
|
|
"bindings",
|
|
"persistence",
|
|
"snippets",
|
|
"ui"
|
|
],
|
|
"modules": [
|
|
"changes-legacy.js"
|
|
],
|
|
"resources": [
|
|
"changesView.css",
|
|
"changesSidebar.css"
|
|
]
|
|
} |