mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-09-30 09:17:09 +08:00
Tim van der Lippe
d47c1d7073
Historically, cm_modes was used to lazily load CodeMirror MIME modes. However, since we are no longer using CodeMirror MIME modes as remote modules, we have switched to using ES imports to load them instead. To that end, we made the `DefaultCodeMirrorMimeMode` extension obsolete, as it became a noop for loading. Moreover, cm_modes was loaded via the module.json infrastructure present in the shell.json file. As such, in release mode these files would properly load, but in a standalone (e.g. unit test) environment, the missing links would cause these modes not to load. To remedy the situation, we perform multiple fixes: 1. Remove the module.json extensions, since we are using ES imports instead. 2. Remove DefaultCodeMirrorMimeMode.js (it is obsolete) 3. Move cm_modes.js into text_editor (this was the only module that actually was loading the full version of CodeMirror) 4. Remove the infrastructure in CodeMirrorTextEditor.js to retrieve the Mime modes (these were effectfully noops). I have personally verified these Mime modes are still correctly loading by opening a personal workspace with various Python/CC files and confirmed that the syntax highlighting in the sources panel is as expected. R=aerotwist@chromium.org Bug: 1127902 Change-Id: Ia3502713be247dc373e80fc3daa65ca7d9ecc1fe Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2577560 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Paul Lewis <aerotwist@chromium.org>
53 lines
1.8 KiB
JSON
53 lines
1.8 KiB
JSON
{
|
|
"modules" : [
|
|
{ "name": "bindings", "type": "autostart" },
|
|
{ "name": "browser_sdk", "type": "autostart" },
|
|
{ "name": "common", "type": "autostart" },
|
|
{ "name": "components", "type": "autostart"},
|
|
{ "name": "console_counters", "type": "autostart" },
|
|
{ "name": "dom_extension", "type": "autostart" },
|
|
{ "name": "extensions", "type": "autostart" },
|
|
{ "name": "host", "type": "autostart" },
|
|
{ "name": "i18n", "type": "autostart" },
|
|
{ "name": "main", "type": "autostart" },
|
|
{ "name": "persistence", "type": "autostart" },
|
|
{ "name": "platform", "type": "autostart" },
|
|
{ "name": "protocol_client", "type": "autostart" },
|
|
{ "name": "root", "type": "autostart" },
|
|
{ "name": "sdk", "type": "autostart" },
|
|
{ "name": "services", "type": "autostart" },
|
|
{ "name": "text_utils", "type": "autostart" },
|
|
{ "name": "theme_support", "type": "autostart" },
|
|
{ "name": "ui", "type": "autostart" },
|
|
{ "name": "workspace", "type": "autostart" },
|
|
|
|
{ "name": "changes" },
|
|
{ "name": "client_variations" },
|
|
{ "name": "cm" },
|
|
{ "name": "color_picker" },
|
|
{ "name": "console" },
|
|
{ "name": "coverage" },
|
|
{ "name": "data_grid" },
|
|
{ "name": "diff" },
|
|
{ "name": "event_listeners" },
|
|
{ "name": "formatter" },
|
|
{ "name": "heap_snapshot_model" },
|
|
{ "name": "inline_editor" },
|
|
{ "name": "input"},
|
|
{ "name": "javascript_metadata" },
|
|
{ "name": "linear_memory_inspector" },
|
|
{ "name": "object_ui" },
|
|
{ "name": "perf_ui" },
|
|
{ "name": "profiler" },
|
|
{ "name": "protocol_monitor"},
|
|
{ "name": "quick_open" },
|
|
{ "name": "search" },
|
|
{ "name": "settings" },
|
|
{ "name": "snippets" },
|
|
{ "name": "source_frame" },
|
|
{ "name": "sources" },
|
|
{ "name": "text_editor" },
|
|
{ "name": "workspace_diff" }
|
|
]
|
|
}
|