Tim van der Lippe
bc38bd6964
After converting the `ui/` folder to ESM, there was a significant performance regression in terms of file size of the `resources.pak`. It turns out that we were not minifying ESM files, but we did do that before with Closure. Update the `copy_devtools_modules` to also invoke rjsmin to minify the JavaScript source code. Before: $ du -h -B K out/Default/resources.pak 12096K out/Default/resources.pak After: $ du -h -B K out/Default/resources.pak 11752K out/Default/resources.pak Before the original CL transforming `ui/` landed: $ du -h -B K out/Default/resources.pak 11860K out/Default/resources.pak This means that after converting `ui/` to ESM, we saved 90KB. We suspect this is because we are no longer transpiling to ES5, but instead serve source ES6. Bug: 1010910 Change-Id: I7dd07ff788d014e9f9a8e25e168c58c010cd00af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837814 Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#702500} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 8d2021d8394b9a248436fb6976070629cdffd961
DevTools Scripts
Development workflow scripts
These are scripts that can be useful to run independently as you're working on Chrome DevTools front-end.
The newer scripts such as for testing and hosted mode are written in Node.js, which has become the standard toolchain for web apps. The older scripts such as building (e.g. bundling and minifying) are written in Python, which has first-class support in Chromium's infrastructure.
Overview
Folders
- build - Python package for generating DevTools debug and release mode
- chrome_debug_launcher - automagically finds Chrome Canary and launches it with debugging flags (e.g. remote debugging port)
- closure - see section on Closure Compiler below
- gulp - experimental build process written in node.js & gulp to remove the dependency on Chromium-specific build tools (i.e. gn and ninja)
- hosted_mode - run DevTools on a localhost development server
- jsdoc_validator - enforces the use of Closure type annotations
- local_node - installs a local runtime of node.js
Python Scripts
- compile_frontend.py - runs closure compiler to do static type analysis
- Note: the compiled outputs are not actually used to run DevTools
- lint_javascript.py - run eslint
- optimize_svg_images.py - manually run when changing svg images
Node.js scripts
The easiest way to run the node.js scripts is to use npm run which displays all the commands. For more information on the specific npm run commands, take a look at the primary devtools front-end readme (../readme.md).
Closure
DevTools manually rolls the closure compiler to ./closure. If you manually roll closure compiler, you will need to re-generate the closure_runner (in ./closure) and jsdoc_validator custom jars using the python scripts in their respective directory.