mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-07 04:26:32 +08:00
Tim van der Lippe
28af9fbe78
This reverts commitaaae6b021a. Reason for revert: always check if tsconfig.json needs to be updated Original change's description: > Revert "Do not overwrite generated files when contents remains the same" > > This reverts commitc1e414725a. > > Reason for revert: Seems to be the cause for CQ compilation errors: > https://ci.chromium.org/ui/p/devtools-frontend/builders/try/devtools_frontend_linux_blink_light_rel/19852/overview > > Original change's description: > > Do not overwrite generated files when contents remains the same > > > > To ensure that build timestamps don't unnecessarily cause full rebuilds, > > make sure that we only write the generated contents to a file (if it > > exists already) if it would be the same. This ensures that the file > > timestamps remain the same, which will lead GN to conclude that the > > build action is a noop (which it is). > > > > On a new year, the file contents would actually be different, so it > > would cause a proper rebuild. However, in all months between when the > > timestamp changes, it won't cause is unnecessarily to rebuild all these > > files, even though the year hasn't changed (but the timestamp it was > > based on did). > > > > R=jacktfranklin@chromium.org > > > > Bug: 1283883 > > Change-Id: I2bdc3a79de710236c1501b21fa505692336cfa82 > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3377942 > > Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org> > > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> > > Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> > > Bug: 1283883 > Change-Id: I938cfe20a7ecf6df6c7becc9fa73a3dcfebe457c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3380583 > Auto-Submit: Simon Zünd <szuend@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bug: 1283883 Change-Id: Iae23d721bdeb4c8af227903a38255ee9fc1bc49d Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3386675 Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
22 lines
671 B
JavaScript
22 lines
671 B
JavaScript
// Copyright 2021 The Chromium Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
const path = require('path');
|
|
const {writeIfChanged} = require('../../../scripts/build/ninja/write-if-changed.js');
|
|
const [, , targetGenDir] = process.argv;
|
|
|
|
let functionImplementation = '';
|
|
|
|
if (process.argv.includes('--should-dcheck')) {
|
|
functionImplementation = `
|
|
if (!condition()) {
|
|
throw new Error(message + ':' + new Error().stack);
|
|
}
|
|
`;
|
|
}
|
|
|
|
writeIfChanged(
|
|
path.join(targetGenDir, 'dcheck.js'),
|
|
`export function DCHECK(condition, message = 'DCHECK') {${functionImplementation}}`);
|