mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-07 12:33:47 +08:00
This reverts commit2b4a9df2d9. Reason for revert: subsequent presubmit uploads should be fixed now. Original change's description: > Revert "Reland "Update stylelint to 14.0.1"" > > This reverts commitf2ea2c940d. > > Reason for revert: https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8831129368825517985/overview > > Original change's description: > > Reland "Update stylelint to 14.0.1" > > > > This reverts commit6c0f161c95. > > > > Reason for revert: the prerequisite CL (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703) has landed > > > > Original change's description: > > > Revert "Update stylelint to 14.0.1" > > > > > > This reverts commit1e08ee816b. > > > > > > Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview > > > > > > Original change's description: > > > > Update stylelint to 14.0.1 > > > > > > > > This also upgrades PostCSS to 8.3.11. > > > > > > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration > > > > R=szuend@chromium.org > > > > > > > > Bug: none > > > > Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541 > > > > Reviewed-by: Simon Zünd <szuend@chromium.org> > > > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> > > > > > > Bug: none > > > Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399 > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Owners-Override: Alex Rudenko <alexrudenko@chromium.org> > > > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> > > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration > > > > Bug: none > > Change-Id: If132a67ee4253d27114caedd66c5ee61c774a6c7 > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264206 > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> > > Reviewed-by: Simon Zünd <szuend@chromium.org> > > Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> > > Bug: none > Change-Id: Idc6c9f5cc1e225c752799461eb0344e94b4ad1e5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264222 > Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration Bug: none Change-Id: I609941d48b46bfcf454b03dcc75a76d460fbe674 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264223 Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
197 lines
4.7 KiB
JavaScript
197 lines
4.7 KiB
JavaScript
'use strict';
|
|
|
|
const valueParser = require('postcss-value-parser');
|
|
|
|
const declarationValueIndex = require('../../utils/declarationValueIndex');
|
|
const getDeclarationValue = require('../../utils/getDeclarationValue');
|
|
const isStandardSyntaxValue = require('../../utils/isStandardSyntaxValue');
|
|
const optionsMatches = require('../../utils/optionsMatches');
|
|
const report = require('../../utils/report');
|
|
const ruleMessages = require('../../utils/ruleMessages');
|
|
const setDeclarationValue = require('../../utils/setDeclarationValue');
|
|
const validateOptions = require('../../utils/validateOptions');
|
|
const { isRegExp, isString } = require('../../utils/validateTypes');
|
|
|
|
const ruleName = 'alpha-value-notation';
|
|
|
|
const messages = ruleMessages(ruleName, {
|
|
expected: (unfixed, fixed) => `Expected "${unfixed}" to be "${fixed}"`,
|
|
});
|
|
|
|
const ALPHA_PROPS = new Set(['opacity', 'shape-image-threshold']);
|
|
const ALPHA_FUNCS = new Set(['hsl', 'hsla', 'hwb', 'lab', 'lch', 'rgb', 'rgba']);
|
|
|
|
/** @type {import('stylelint').Rule} */
|
|
const rule = (primary, secondaryOptions, context) => {
|
|
return (root, result) => {
|
|
const validOptions = validateOptions(
|
|
result,
|
|
ruleName,
|
|
{
|
|
actual: primary,
|
|
possible: ['number', 'percentage'],
|
|
},
|
|
{
|
|
actual: secondaryOptions,
|
|
possible: {
|
|
exceptProperties: [isString, isRegExp],
|
|
},
|
|
optional: true,
|
|
},
|
|
);
|
|
|
|
if (!validOptions) return;
|
|
|
|
const optionFuncs = Object.freeze({
|
|
number: {
|
|
expFunc: isNumber,
|
|
fixFunc: asNumber,
|
|
},
|
|
percentage: {
|
|
expFunc: isPercentage,
|
|
fixFunc: asPercentage,
|
|
},
|
|
});
|
|
|
|
root.walkDecls((decl) => {
|
|
let needsFix = false;
|
|
const parsedValue = valueParser(getDeclarationValue(decl));
|
|
|
|
parsedValue.walk((node) => {
|
|
/** @type {import('postcss-value-parser').Node | undefined} */
|
|
let alpha;
|
|
|
|
if (ALPHA_PROPS.has(decl.prop.toLowerCase())) {
|
|
alpha = findAlphaInValue(node);
|
|
} else {
|
|
if (node.type !== 'function') return;
|
|
|
|
if (!ALPHA_FUNCS.has(node.value.toLowerCase())) return;
|
|
|
|
alpha = findAlphaInFunction(node);
|
|
}
|
|
|
|
if (!alpha) return;
|
|
|
|
const { value } = alpha;
|
|
|
|
if (!isStandardSyntaxValue(value)) return;
|
|
|
|
if (!isNumber(value) && !isPercentage(value)) return;
|
|
|
|
/** @type {'number' | 'percentage'} */
|
|
let expectation = primary;
|
|
|
|
if (optionsMatches(secondaryOptions, 'exceptProperties', decl.prop)) {
|
|
if (expectation === 'number') {
|
|
expectation = 'percentage';
|
|
} else if (expectation === 'percentage') {
|
|
expectation = 'number';
|
|
}
|
|
}
|
|
|
|
if (optionFuncs[expectation].expFunc(value)) return;
|
|
|
|
const fixed = optionFuncs[expectation].fixFunc(value);
|
|
const unfixed = value;
|
|
|
|
if (context.fix) {
|
|
alpha.value = String(fixed);
|
|
needsFix = true;
|
|
|
|
return;
|
|
}
|
|
|
|
report({
|
|
message: messages.expected(unfixed, fixed),
|
|
node: decl,
|
|
index: declarationValueIndex(decl) + alpha.sourceIndex,
|
|
result,
|
|
ruleName,
|
|
});
|
|
});
|
|
|
|
if (needsFix) {
|
|
setDeclarationValue(decl, parsedValue.toString());
|
|
}
|
|
});
|
|
};
|
|
};
|
|
|
|
/**
|
|
* @param {string} value
|
|
* @returns {string | undefined}
|
|
*/
|
|
function asPercentage(value) {
|
|
const number = Number(value);
|
|
|
|
return `${Number((number * 100).toPrecision(3))}%`;
|
|
}
|
|
|
|
/**
|
|
* @param {string} value
|
|
* @returns {string | undefined}
|
|
*/
|
|
function asNumber(value) {
|
|
const dimension = valueParser.unit(value);
|
|
|
|
if (!dimension) return undefined;
|
|
|
|
const number = Number(dimension.number);
|
|
|
|
return Number((number / 100).toPrecision(3)).toString();
|
|
}
|
|
|
|
/**
|
|
* @template {import('postcss-value-parser').Node} T
|
|
* @param {T} node
|
|
* @returns {T | undefined}
|
|
*/
|
|
function findAlphaInValue(node) {
|
|
return node.type === 'word' || node.type === 'function' ? node : undefined;
|
|
}
|
|
|
|
/**
|
|
* @param {import('postcss-value-parser').FunctionNode} node
|
|
* @returns {import('postcss-value-parser').Node | undefined}
|
|
*/
|
|
function findAlphaInFunction(node) {
|
|
const args = node.nodes.filter(({ type }) => type === 'word' || type === 'function');
|
|
|
|
if (args.length === 4) return args[3];
|
|
|
|
const slashNodeIndex = node.nodes.findIndex(({ type, value }) => type === 'div' && value === '/');
|
|
|
|
if (slashNodeIndex !== -1) {
|
|
const nodesAfterSlash = node.nodes.slice(slashNodeIndex + 1, node.nodes.length);
|
|
|
|
return nodesAfterSlash.find(({ type }) => type === 'word');
|
|
}
|
|
|
|
return undefined;
|
|
}
|
|
|
|
/**
|
|
* @param {string} value
|
|
* @returns {boolean}
|
|
*/
|
|
function isPercentage(value) {
|
|
const dimension = valueParser.unit(value);
|
|
|
|
return dimension && dimension.unit === '%';
|
|
}
|
|
|
|
/**
|
|
* @param {string} value
|
|
* @returns {boolean}
|
|
*/
|
|
function isNumber(value) {
|
|
const dimension = valueParser.unit(value);
|
|
|
|
return dimension && dimension.unit === '';
|
|
}
|
|
|
|
rule.ruleName = ruleName;
|
|
rule.messages = messages;
|
|
module.exports = rule;
|