mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-07 12:33:47 +08:00
This reverts commit2b4a9df2d9. Reason for revert: subsequent presubmit uploads should be fixed now. Original change's description: > Revert "Reland "Update stylelint to 14.0.1"" > > This reverts commitf2ea2c940d. > > Reason for revert: https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8831129368825517985/overview > > Original change's description: > > Reland "Update stylelint to 14.0.1" > > > > This reverts commit6c0f161c95. > > > > Reason for revert: the prerequisite CL (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703) has landed > > > > Original change's description: > > > Revert "Update stylelint to 14.0.1" > > > > > > This reverts commit1e08ee816b. > > > > > > Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview > > > > > > Original change's description: > > > > Update stylelint to 14.0.1 > > > > > > > > This also upgrades PostCSS to 8.3.11. > > > > > > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration > > > > R=szuend@chromium.org > > > > > > > > Bug: none > > > > Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541 > > > > Reviewed-by: Simon Zünd <szuend@chromium.org> > > > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> > > > > > > Bug: none > > > Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399 > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Owners-Override: Alex Rudenko <alexrudenko@chromium.org> > > > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> > > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration > > > > Bug: none > > Change-Id: If132a67ee4253d27114caedd66c5ee61c774a6c7 > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264206 > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> > > Reviewed-by: Simon Zünd <szuend@chromium.org> > > Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> > > Bug: none > Change-Id: Idc6c9f5cc1e225c752799461eb0344e94b4ad1e5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264222 > Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration Bug: none Change-Id: I609941d48b46bfcf454b03dcc75a76d460fbe674 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264223 Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
107 lines
3.0 KiB
JavaScript
107 lines
3.0 KiB
JavaScript
'use strict';
|
|
|
|
const getDeclarationValue = require('../../utils/getDeclarationValue');
|
|
const report = require('../../utils/report');
|
|
const ruleMessages = require('../../utils/ruleMessages');
|
|
const setDeclarationValue = require('../../utils/setDeclarationValue');
|
|
const validateOptions = require('../../utils/validateOptions');
|
|
const valueParser = require('postcss-value-parser');
|
|
const { isNumber } = require('../../utils/validateTypes');
|
|
|
|
const ruleName = 'function-max-empty-lines';
|
|
|
|
const messages = ruleMessages(ruleName, {
|
|
expected: (max) => `Expected no more than ${max} empty ${max === 1 ? 'line' : 'lines'}`,
|
|
});
|
|
|
|
/**
|
|
* @param {import('postcss').Declaration} decl
|
|
*/
|
|
function placeIndexOnValueStart(decl) {
|
|
if (decl.raws.between == null) throw new Error('`between` must be present');
|
|
|
|
return decl.prop.length + decl.raws.between.length - 1;
|
|
}
|
|
|
|
/** @type {import('stylelint').Rule} */
|
|
const rule = (primary, _secondaryOptions, context) => {
|
|
const maxAdjacentNewlines = primary + 1;
|
|
|
|
return (root, result) => {
|
|
const validOptions = validateOptions(result, ruleName, {
|
|
actual: primary,
|
|
possible: isNumber,
|
|
});
|
|
|
|
if (!validOptions) {
|
|
return;
|
|
}
|
|
|
|
const violatedCRLFNewLinesRegex = new RegExp(`(?:\r\n){${maxAdjacentNewlines + 1},}`);
|
|
const violatedLFNewLinesRegex = new RegExp(`\n{${maxAdjacentNewlines + 1},}`);
|
|
const allowedLFNewLinesString = context.fix ? '\n'.repeat(maxAdjacentNewlines) : '';
|
|
const allowedCRLFNewLinesString = context.fix ? '\r\n'.repeat(maxAdjacentNewlines) : '';
|
|
|
|
root.walkDecls((decl) => {
|
|
if (!decl.value.includes('(')) {
|
|
return;
|
|
}
|
|
|
|
const stringValue = getDeclarationValue(decl);
|
|
/** @type {Array<[string, string]>} */
|
|
const splittedValue = [];
|
|
let sourceIndexStart = 0;
|
|
|
|
valueParser(stringValue).walk((node) => {
|
|
if (
|
|
node.type !== 'function' /* ignore non functions */ ||
|
|
node.value.length === 0 /* ignore sass lists */
|
|
) {
|
|
return;
|
|
}
|
|
|
|
const stringifiedNode = valueParser.stringify(node);
|
|
|
|
if (
|
|
!violatedLFNewLinesRegex.test(stringifiedNode) &&
|
|
!violatedCRLFNewLinesRegex.test(stringifiedNode)
|
|
) {
|
|
return;
|
|
}
|
|
|
|
if (context.fix) {
|
|
const newNodeString = stringifiedNode
|
|
.replace(new RegExp(violatedLFNewLinesRegex, 'gm'), allowedLFNewLinesString)
|
|
.replace(new RegExp(violatedCRLFNewLinesRegex, 'gm'), allowedCRLFNewLinesString);
|
|
|
|
splittedValue.push([
|
|
stringValue.slice(sourceIndexStart, node.sourceIndex),
|
|
newNodeString,
|
|
]);
|
|
sourceIndexStart = node.sourceIndex + stringifiedNode.length;
|
|
} else {
|
|
report({
|
|
message: messages.expected(primary),
|
|
node: decl,
|
|
index: placeIndexOnValueStart(decl) + node.sourceIndex,
|
|
result,
|
|
ruleName,
|
|
});
|
|
}
|
|
});
|
|
|
|
if (context.fix && splittedValue.length > 0) {
|
|
const updatedValue =
|
|
splittedValue.reduce((acc, curr) => acc + curr[0] + curr[1], '') +
|
|
stringValue.slice(sourceIndexStart);
|
|
|
|
setDeclarationValue(decl, updatedValue);
|
|
}
|
|
});
|
|
};
|
|
};
|
|
|
|
rule.ruleName = ruleName;
|
|
rule.messages = messages;
|
|
module.exports = rule;
|