Files
Tim van der Lippe 16b822804c Reland "Reland "Update stylelint to 14.0.1""
This reverts commit 2b4a9df2d9.

Reason for revert: subsequent presubmit uploads should be fixed now.

Original change's description:
> Revert "Reland "Update stylelint to 14.0.1""
>
> This reverts commit f2ea2c940d.
>
> Reason for revert: https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8831129368825517985/overview
>
> Original change's description:
> > Reland "Update stylelint to 14.0.1"
> >
> > This reverts commit 6c0f161c95.
> >
> > Reason for revert: the prerequisite CL (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703) has landed
> >
> > Original change's description:
> > > Revert "Update stylelint to 14.0.1"
> > >
> > > This reverts commit 1e08ee816b.
> > >
> > > Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview
> > >
> > > Original change's description:
> > > > Update stylelint to 14.0.1
> > > >
> > > > This also upgrades PostCSS to 8.3.11.
> > > >
> > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
> > > > R=​szuend@chromium.org
> > > >
> > > > Bug: none
> > > > Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541
> > > > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> > >
> > > Bug: none
> > > Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Owners-Override: Alex Rudenko <alexrudenko@chromium.org>
> > > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
> >
> > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
> >
> > Bug: none
> > Change-Id: If132a67ee4253d27114caedd66c5ee61c774a6c7
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264206
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
>
> Bug: none
> Change-Id: Idc6c9f5cc1e225c752799461eb0344e94b4ad1e5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264222
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration

Bug: none
Change-Id: I609941d48b46bfcf454b03dcc75a76d460fbe674
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264223
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
2021-11-08 14:47:39 +00:00

169 lines
4.6 KiB
JavaScript

'use strict';
const declarationValueIndex = require('../../utils/declarationValueIndex');
const getDeclarationValue = require('../../utils/getDeclarationValue');
const isSingleLineString = require('../../utils/isSingleLineString');
const isStandardSyntaxFunction = require('../../utils/isStandardSyntaxFunction');
const report = require('../../utils/report');
const ruleMessages = require('../../utils/ruleMessages');
const setDeclarationValue = require('../../utils/setDeclarationValue');
const validateOptions = require('../../utils/validateOptions');
const valueParser = require('postcss-value-parser');
const ruleName = 'function-parentheses-space-inside';
const messages = ruleMessages(ruleName, {
expectedOpening: 'Expected single space after "("',
rejectedOpening: 'Unexpected whitespace after "("',
expectedClosing: 'Expected single space before ")"',
rejectedClosing: 'Unexpected whitespace before ")"',
expectedOpeningSingleLine: 'Expected single space after "(" in a single-line function',
rejectedOpeningSingleLine: 'Unexpected whitespace after "(" in a single-line function',
expectedClosingSingleLine: 'Expected single space before ")" in a single-line function',
rejectedClosingSingleLine: 'Unexpected whitespace before ")" in a single-line function',
});
/** @type {import('stylelint').Rule} */
const rule = (primary, _secondaryOptions, context) => {
return (root, result) => {
const validOptions = validateOptions(result, ruleName, {
actual: primary,
possible: ['always', 'never', 'always-single-line', 'never-single-line'],
});
if (!validOptions) {
return;
}
root.walkDecls((decl) => {
if (!decl.value.includes('(')) {
return;
}
let hasFixed = false;
const declValue = getDeclarationValue(decl);
const parsedValue = valueParser(declValue);
parsedValue.walk((valueNode) => {
if (valueNode.type !== 'function') {
return;
}
if (!isStandardSyntaxFunction(valueNode)) {
return;
}
// Ignore function without parameters
if (!valueNode.nodes.length) {
return;
}
const functionString = valueParser.stringify(valueNode);
const isSingleLine = isSingleLineString(functionString);
// Check opening ...
const openingIndex = valueNode.sourceIndex + valueNode.value.length + 1;
if (primary === 'always' && valueNode.before !== ' ') {
if (context.fix) {
hasFixed = true;
valueNode.before = ' ';
} else {
complain(messages.expectedOpening, openingIndex);
}
}
if (primary === 'never' && valueNode.before !== '') {
if (context.fix) {
hasFixed = true;
valueNode.before = '';
} else {
complain(messages.rejectedOpening, openingIndex);
}
}
if (isSingleLine && primary === 'always-single-line' && valueNode.before !== ' ') {
if (context.fix) {
hasFixed = true;
valueNode.before = ' ';
} else {
complain(messages.expectedOpeningSingleLine, openingIndex);
}
}
if (isSingleLine && primary === 'never-single-line' && valueNode.before !== '') {
if (context.fix) {
hasFixed = true;
valueNode.before = '';
} else {
complain(messages.rejectedOpeningSingleLine, openingIndex);
}
}
// Check closing ...
const closingIndex = valueNode.sourceIndex + functionString.length - 2;
if (primary === 'always' && valueNode.after !== ' ') {
if (context.fix) {
hasFixed = true;
valueNode.after = ' ';
} else {
complain(messages.expectedClosing, closingIndex);
}
}
if (primary === 'never' && valueNode.after !== '') {
if (context.fix) {
hasFixed = true;
valueNode.after = '';
} else {
complain(messages.rejectedClosing, closingIndex);
}
}
if (isSingleLine && primary === 'always-single-line' && valueNode.after !== ' ') {
if (context.fix) {
hasFixed = true;
valueNode.after = ' ';
} else {
complain(messages.expectedClosingSingleLine, closingIndex);
}
}
if (isSingleLine && primary === 'never-single-line' && valueNode.after !== '') {
if (context.fix) {
hasFixed = true;
valueNode.after = '';
} else {
complain(messages.rejectedClosingSingleLine, closingIndex);
}
}
});
if (hasFixed) {
setDeclarationValue(decl, parsedValue.toString());
}
/**
* @param {string} message
* @param {number} offset
*/
function complain(message, offset) {
report({
ruleName,
result,
message,
node: decl,
index: declarationValueIndex(decl) + offset,
});
}
});
};
};
rule.ruleName = ruleName;
rule.messages = messages;
module.exports = rule;