mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-08 12:53:45 +08:00
This reverts commit2b4a9df2d9. Reason for revert: subsequent presubmit uploads should be fixed now. Original change's description: > Revert "Reland "Update stylelint to 14.0.1"" > > This reverts commitf2ea2c940d. > > Reason for revert: https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8831129368825517985/overview > > Original change's description: > > Reland "Update stylelint to 14.0.1" > > > > This reverts commit6c0f161c95. > > > > Reason for revert: the prerequisite CL (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703) has landed > > > > Original change's description: > > > Revert "Update stylelint to 14.0.1" > > > > > > This reverts commit1e08ee816b. > > > > > > Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview > > > > > > Original change's description: > > > > Update stylelint to 14.0.1 > > > > > > > > This also upgrades PostCSS to 8.3.11. > > > > > > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration > > > > R=szuend@chromium.org > > > > > > > > Bug: none > > > > Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541 > > > > Reviewed-by: Simon Zünd <szuend@chromium.org> > > > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> > > > > > > Bug: none > > > Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399 > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Owners-Override: Alex Rudenko <alexrudenko@chromium.org> > > > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> > > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration > > > > Bug: none > > Change-Id: If132a67ee4253d27114caedd66c5ee61c774a6c7 > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264206 > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> > > Reviewed-by: Simon Zünd <szuend@chromium.org> > > Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> > > Bug: none > Change-Id: Idc6c9f5cc1e225c752799461eb0344e94b4ad1e5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264222 > Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration Bug: none Change-Id: I609941d48b46bfcf454b03dcc75a76d460fbe674 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264223 Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
130 lines
3.3 KiB
JavaScript
130 lines
3.3 KiB
JavaScript
'use strict';
|
|
|
|
const atRuleParamIndex = require('../../utils/atRuleParamIndex');
|
|
const functionArgumentsSearch = require('../../utils/functionArgumentsSearch');
|
|
const isStandardSyntaxUrl = require('../../utils/isStandardSyntaxUrl');
|
|
const optionsMatches = require('../../utils/optionsMatches');
|
|
const report = require('../../utils/report');
|
|
const ruleMessages = require('../../utils/ruleMessages');
|
|
const validateOptions = require('../../utils/validateOptions');
|
|
|
|
const ruleName = 'function-url-quotes';
|
|
|
|
const messages = ruleMessages(ruleName, {
|
|
expected: (functionName) => `Expected quotes around "${functionName}" function argument`,
|
|
rejected: (functionName) => `Unexpected quotes around "${functionName}" function argument`,
|
|
});
|
|
|
|
/** @type {import('stylelint').Rule} */
|
|
const rule = (primary, secondaryOptions) => {
|
|
return (root, result) => {
|
|
const validOptions = validateOptions(
|
|
result,
|
|
ruleName,
|
|
{
|
|
actual: primary,
|
|
possible: ['always', 'never'],
|
|
},
|
|
{
|
|
actual: secondaryOptions,
|
|
possible: {
|
|
except: ['empty'],
|
|
},
|
|
optional: true,
|
|
},
|
|
);
|
|
|
|
if (!validOptions) {
|
|
return;
|
|
}
|
|
|
|
root.walkAtRules(checkAtRuleParams);
|
|
root.walkDecls(checkDeclParams);
|
|
|
|
/**
|
|
* @param {import('postcss').Declaration} decl
|
|
*/
|
|
function checkDeclParams(decl) {
|
|
functionArgumentsSearch(decl.toString().toLowerCase(), 'url', (args, index) => {
|
|
checkArgs(args, decl, index, 'url');
|
|
});
|
|
}
|
|
|
|
/**
|
|
* @param {import('postcss').AtRule} atRule
|
|
*/
|
|
function checkAtRuleParams(atRule) {
|
|
const atRuleParamsLowerCase = atRule.params.toLowerCase();
|
|
|
|
functionArgumentsSearch(atRuleParamsLowerCase, 'url', (args, index) => {
|
|
checkArgs(args, atRule, index + atRuleParamIndex(atRule), 'url');
|
|
});
|
|
functionArgumentsSearch(atRuleParamsLowerCase, 'url-prefix', (args, index) => {
|
|
checkArgs(args, atRule, index + atRuleParamIndex(atRule), 'url-prefix');
|
|
});
|
|
functionArgumentsSearch(atRuleParamsLowerCase, 'domain', (args, index) => {
|
|
checkArgs(args, atRule, index + atRuleParamIndex(atRule), 'domain');
|
|
});
|
|
}
|
|
|
|
/**
|
|
* @param {string} args
|
|
* @param {import('postcss').Node} node
|
|
* @param {number} index
|
|
* @param {string} functionName
|
|
*/
|
|
function checkArgs(args, node, index, functionName) {
|
|
let shouldHasQuotes = primary === 'always';
|
|
|
|
const leftTrimmedArgs = args.trimStart();
|
|
|
|
if (!isStandardSyntaxUrl(leftTrimmedArgs)) {
|
|
return;
|
|
}
|
|
|
|
const complaintIndex = index + args.length - leftTrimmedArgs.length;
|
|
const hasQuotes = leftTrimmedArgs.startsWith("'") || leftTrimmedArgs.startsWith('"');
|
|
|
|
const trimmedArg = args.trim();
|
|
const isEmptyArgument = ['', "''", '""'].includes(trimmedArg);
|
|
|
|
if (optionsMatches(secondaryOptions, 'except', 'empty') && isEmptyArgument) {
|
|
shouldHasQuotes = !shouldHasQuotes;
|
|
}
|
|
|
|
if (shouldHasQuotes) {
|
|
if (hasQuotes) {
|
|
return;
|
|
}
|
|
|
|
complain(messages.expected(functionName), node, complaintIndex);
|
|
} else {
|
|
if (!hasQuotes) {
|
|
return;
|
|
}
|
|
|
|
complain(messages.rejected(functionName), node, complaintIndex);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @param {string} message
|
|
* @param {import('postcss').Node} node
|
|
* @param {number} index
|
|
*/
|
|
function complain(message, node, index) {
|
|
report({
|
|
message,
|
|
node,
|
|
index,
|
|
result,
|
|
ruleName,
|
|
});
|
|
}
|
|
};
|
|
};
|
|
|
|
rule.ruleName = ruleName;
|
|
rule.messages = messages;
|
|
module.exports = rule;
|