mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-06 20:11:38 +08:00
Tim van der Lippe
5386d3bb32
This rule ensures that all custom element definitions are either placed in `ui/components` or in a `components` sub-folder of a panel. Since `inline_editor` and `ui/legacy` still have custom element definitions in their respective folders, these are still allowed for now. R=jacktfranklin@chromium.org Bug: 1206211 Change-Id: I137677ab947a8359d9164ddf1c7dfc421b6dfea9 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2874683 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
44 lines
1.3 KiB
JavaScript
44 lines
1.3 KiB
JavaScript
// Copyright 2021 The Chromium Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
'use strict';
|
|
|
|
const rule = require('../lib/custom_element_definitions_location.js');
|
|
const ruleTester = new (require('eslint').RuleTester)({
|
|
parserOptions: {ecmaVersion: 9, sourceType: 'module'},
|
|
parser: require.resolve('@typescript-eslint/parser'),
|
|
});
|
|
|
|
ruleTester.run('custom_element_definitions_location', rule, {
|
|
valid: [
|
|
{
|
|
code: 'class Foo extends HTMLElement {}',
|
|
filename: 'front_end/ui/components/foo/Foo.ts',
|
|
},
|
|
{
|
|
code: 'class Foo extends HTMLElement {}',
|
|
filename: 'front_end/panels/issues/components/Foo.ts',
|
|
},
|
|
{
|
|
code: 'class Foo extends HTMLElement {}',
|
|
filename: 'front_end/panels/issues/components/nested/folder/Foo.ts',
|
|
},
|
|
{
|
|
code: 'class Foo extends OtherClass {}',
|
|
filename: 'front_end/models/some/Model.ts',
|
|
},
|
|
],
|
|
invalid: [
|
|
{
|
|
code: 'class Foo extends HTMLElement {}',
|
|
filename: 'front_end/panels/issues/IssuesPanel.ts',
|
|
errors: [{messageId: 'definitionInWrongFolder'}]
|
|
},
|
|
{
|
|
code: 'class Foo extends HTMLElement {}',
|
|
filename: 'front_end/models/bindings/Bindings.ts',
|
|
errors: [{messageId: 'definitionInWrongFolder'}]
|
|
},
|
|
]
|
|
});
|