mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-06 12:01:40 +08:00
Simon Zünd
8acb7db049
This reverts commit 056ad78a21.
Reason for revert: Suspected to make e2e tests on the windows bot more flaky.
Original change's description:
> Reland: [e2e] Use pre-allocated DevTools and target tabs
>
> This CL relands https://crrev.com/c/3461563.
> The main difference is that while we enable the pool implementation,
> we configure the pool size to be 0 unconditionally. This way, we get
> the benefit of spinning up fresh DevTools and inspected tabs while
> preserving the old behavior of doing the setup of these tabs right
> before a test executes and not in the background.
>
> Original CL description:
> > [e2e] Use pre-allocated DevTools and target tabs
> >
> > This CL changes the conductor to use new DevTools frontend and target
> > tabs for each individual test. A pool prepares a set of frontend/target
> > tab pairs in the background so the conductor doesn't need to waste time
> > resetting tabs in between tests.
> >
> > For debugging e2e tests we disable the pool and use on-demand tab
> > creation instead. It would be annoying to deal with ~12 open tabs
> > and trying to find the right ones in a debugging session.
> >
> > This CL also increases the general e2e test timeout from 5 to 10
> > seconds. This is because of the more volatile nature of e2e tests
> > now. In some edge cases a tab for the currently running test might
> > not get enough CPU time to run in time. This can happen when a
> > serious of short running tests deplete the pool and multiple
> > Devtools frontend instances have to be prepared in the background.
> >
> > R=jacktfranklin@chromium.org
> >
> > Bug: 1297458
> > Change-Id: I6b6c4a15e5d83f7e2bdc6082972993df179a5d87
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3461563
> > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
> > Commit-Queue: Simon Zünd <szuend@chromium.org>
>
> Bug: 1297458
> Change-Id: Iac0294116f1a9e762a3847bcb0738955bba957b2
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3641403
> Commit-Queue: Simon Zünd <szuend@chromium.org>
> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Bug: 1297458
Change-Id: I4758c4c9cb3e7919f12bccc28c9310ab7225c729
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3645451
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>