mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-20 13:35:11 +08:00
Jack Lynch
d529e88005
This reverts commitf3b391e525. Reason for revert: Some strings are different on mac, creating a reland to investigate a fix Original change's description: > Revert "Settings: Add e2e tests for shortcuts tab" > > This reverts commit137f0a1b84. > > Reason for revert: Consistently fails on Mac Bot, first failure: > https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket.appspot.com/8864995173425920000/+/steps/E2E_tests/0/stdout > > Original change's description: > > Settings: Add e2e tests for shortcuts tab > > > > This CL adds several end to end tests for the shortcuts settings tab, > > including the keyboard shortcut editor. > > > > Bug: 174309 > > Change-Id: I293f233f9afde298cb618fbdbb6c9b147b895daf > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2504790 > > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org> > > Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com> > > Commit-Queue: Jack Lynch <jalyn@microsoft.com> > > TBR=jalyn@microsoft.com,tvanderlippe@chromium.org,patrick.brosset@microsoft.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 174309 > Change-Id: Ie5ee124b3ad760dead6745e33591eb7578b69e88 > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2512225 > Reviewed-by: Simon Zünd <szuend@chromium.org> > Commit-Queue: Simon Zünd <szuend@chromium.org> TBR=szuend@chromium.org,jalyn@microsoft.com,tvanderlippe@chromium.org,patrick.brosset@microsoft.com # Not skipping CQ checks because this is a reland. Bug: 174309 Change-Id: I8382dfab7a3e3a3dfaaa36e834d67636b33a6b9c Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2512850 Reviewed-by: Jack Lynch <jalyn@microsoft.com> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Jack Lynch <jalyn@microsoft.com>
15 lines
351 B
Plaintext
15 lines
351 B
Plaintext
# Copyright 2020 The Chromium Authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
import("../../../third_party/typescript/typescript.gni")
|
|
|
|
node_ts_library("settings") {
|
|
sources = [ "shortcut_settings_test.ts" ]
|
|
|
|
deps = [
|
|
"../../shared",
|
|
"../helpers",
|
|
]
|
|
}
|