Mandy Chen
881e939472
Discovered a bug in check_gn.js, which is part of the presubmit check that verifies all the devtools frontend files are included in devtools/BUILD.gn. The bug prevents missing module.json files from being reported. Output of running npm run check-gn Before the fix: DevTools BUILD.gn checker passed After: DevTools BUILD.gn checker detected errors! There's an issue with: D:\chromium\src\third_party\blink\renderer\devtools\BUILD.gn Missing file in BUILD.gn for all_devtools_files: "front_end\elements_test_runner\module.json", Missing file in BUILD.gn for all_devtools_files: "front_end\persistence\module.json", Missing file in BUILD.gn for all_devtools_files: "front_end\search\module.json", Missing file in BUILD.gn for all_devtools_files: "front_end\services\module.json", Missing file in BUILD.gn for all_devtools_files: "front_end\terminal\module.json", Missing file in BUILD.gn for all_devtools_files: "front_end\worker_service\module.json", I added these missing module.json files to BUILD.gn. Change-Id: I05a72e353475af142c13f0644fd430361edfff72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576409 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Original-Commit-Position: refs/heads/master@{#653018} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 66c0e97960fed83511d320eded9f028e1cb678ad
DevTools Scripts
Development workflow scripts
These are scripts that can be useful to run independently as you're working on Chrome DevTools front-end.
The newer scripts such as for testing and hosted mode are written in Node.js, which has become the standard toolchain for web apps. The older scripts such as building (e.g. bundling and minifying) are written in Python, which has first-class support in Chromium's infrastructure.
Overview
Folders
- build - Python package for generating DevTools debug and release mode
- chrome_debug_launcher - automagically finds Chrome Canary and launches it with debugging flags (e.g. remote debugging port)
- closure - see section on Closure Compiler below
- gulp - experimental build process written in node.js & gulp to remove the dependency on Chromium-specific build tools (i.e. gn and ninja)
- hosted_mode - run DevTools on a localhost development server
- jsdoc_validator - enforces the use of Closure type annotations
- local_node - installs a local runtime of node.js
Python Scripts
- convert_svg_images_to_png.py - manually run when adding svg images
- compile_frontend.py - runs closure compiler to do static type analysis
- Note: the compiled outputs are not actually used to run DevTools
- lint_javascript.py - run eslint
- optimize_png_images.py - manually run when adding png images
Node.js scripts
The easiest way to run the node.js scripts is to use npm run which displays all the commands. For more information on the specific npm run commands, take a look at the primary devtools front-end readme (../readme.md).
Closure
DevTools manually rolls the closure compiler to ./closure. If you manually roll closure compiler, you will need to re-generate the closure_runner (in ./closure) and jsdoc_validator custom jars using the python scripts in their respective directory.