Files
react-native-devtools-frontend/scripts/check_gn.js
T
Tim van der Lippe 8fa9d45123 Build common-legacy.js with devtools_entrypoint
To continue to move away from `build_release_applications.py`, move
building `common-legacy.js` into `devtools_entrypoint`. In the end,
it will allow us to remove `_rollup_module` from
`build_release_applications.py`.

The logic in `build_release_applications.py` is updated to assume
a pregenerated `-legacy.js` file based on the `pre_generates_legacy`
option in the `module.json` file. Once all `-legacy.js are migrated,
we can remove this option once again.

To make sure that we Rollup properly, we should assume that an
entrypoint in the same folder is regarded as external. Otherwise,
we would rollup the contents of `common.js` into `common-legacy.js`,
which is not what we want.

R=aerotwist@chromium.org

Bug: 1131500
Change-Id: Idcda3e1c2436a0bebb36501523c8d586d6e86fac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2450297
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
2020-10-14 11:42:10 +00:00

174 lines
5.8 KiB
JavaScript

// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
'use strict';
const fs = require('fs');
const path = require('path');
const FRONTEND_PATH = path.resolve(__dirname, '..', 'front_end');
const manifestModules = [];
for (const config
of ['inspector.json', 'devtools_app.json', 'js_app.json', 'node_app.json', 'shell.json', 'worker_app.json']) {
manifestModules.push(...require(path.resolve(FRONTEND_PATH, config)).modules);
}
const gnPath = path.resolve(__dirname, '..', 'BUILD.gn');
const gnFile = fs.readFileSync(gnPath, 'utf-8');
const gnLines = gnFile.split('\n');
/**
* Ensures that generated module files are in the right list in BUILD.gn.
* This is primarily to avoid remote modules from accidentally getting
* bundled with the main Chrome binary.
*/
function checkNonAutostartNonRemoteModules() {
const errors = [];
const gnVariable = 'generated_non_autostart_non_remote_modules';
const lines = selectGNLines(`${gnVariable} = [`, ']');
if (!lines.length) {
return [
'Could not identify non-autostart non-remote modules in gn file',
'Please look at: ' + __filename,
];
}
const text = lines.join('\n');
const modules = manifestModules.filter(m => m.type !== 'autostart').map(m => m.name);
const missingModules = modules.filter(m => !text.includes(`${m}/${m}_module.js`));
if (missingModules.length) {
errors.push(`Check that you've included [${missingModules.join(', ')}] modules in: ` + gnVariable);
}
// e.g. "$resources_out_dir/lighthouse/lighthouse_module.js" => "lighthouse"
const mapLineToModuleName = line => line.split('/')[2].split('_module')[0];
const extraneousModules = lines.map(mapLineToModuleName).filter(module => !modules.includes(module));
if (extraneousModules.length) {
errors.push(`Found extraneous modules [${extraneousModules.join(', ')}] in: ` + gnVariable);
}
return errors;
}
/**
* Ensures that all source files (according to the various module.json files) are
* listed in BUILD.gn.
*/
function checkAllDevToolsFiles() {
return checkGNVariable('all_devtools_files', 'all_devtools_files', moduleJSON => {
const resources = moduleJSON.resources || [];
return [
'module.json',
...resources,
];
});
}
function checkDevtoolsModuleEntrypoints() {
return checkGNVariable(
'devtools_module_entrypoints', 'devtools_module_entrypoint_sources',
(moduleJSON, folderName) => {
if (moduleJSON.pre_generates_legacy) {
return [];
}
return (moduleJSON.modules || []).filter(fileName => {
return fileName === `${folderName}-legacy.js`;
});
},
buildGNPath => filename => {
const relativePath = path.normalize(`${buildGNPath}/${filename}`);
return `"${relativePath}",`;
});
}
function checkGNVariable(fileName, gnVariable, obtainFiles, obtainRelativePath) {
const filePath = path.resolve(__dirname, '..', `${fileName}.gni`);
const fileContent = fs.readFileSync(filePath, 'utf-8');
const linesToCheck = fileContent.split('\n');
const errors = [];
const excludedFiles =
['axe.js', 'formatter_worker/', 'third_party/lighthouse/', 'third_party/i18n/'].map(path.normalize);
const lines = selectGNLines(`${gnVariable} = [`, ']', linesToCheck).map(path.normalize);
if (!lines.length) {
return [
`Could not identify ${gnVariable} list in gn file`,
'Please look at: ' + __filename,
];
}
const gnFiles = new Set(lines);
let moduleFiles = [];
function addModuleFilesForDirectory(moduleJSONPath, buildGNPath, folderName) {
const moduleJSON = require(moduleJSONPath);
const files = obtainFiles(moduleJSON, folderName)
.map(obtainRelativePath && obtainRelativePath(buildGNPath) || relativePathFromBuildGN)
.filter(file => excludedFiles.every(excludedFile => !file.includes(excludedFile)));
moduleFiles = moduleFiles.concat(files);
function relativePathFromBuildGN(filename) {
const relativePath = path.normalize(`front_end/${buildGNPath}/${filename}`);
return `"${relativePath}",`;
}
}
function traverseDirectoriesForModuleJSONFiles(folderName, buildGNPath) {
if (!fs.lstatSync(folderName).isDirectory()) {
return;
}
const moduleJSONPath = path.join(folderName, 'module.json');
if (fs.existsSync(moduleJSONPath)) {
addModuleFilesForDirectory(moduleJSONPath, buildGNPath, path.basename(folderName));
}
fs.readdirSync(folderName).forEach(nestedModuleName => {
traverseDirectoriesForModuleJSONFiles(
path.join(folderName, nestedModuleName), `${buildGNPath}/${nestedModuleName}`);
});
}
fs.readdirSync(FRONTEND_PATH).forEach(moduleName => {
traverseDirectoriesForModuleJSONFiles(path.join(FRONTEND_PATH, moduleName), moduleName);
});
for (const file of moduleFiles) {
if (!gnFiles.has(file)) {
errors.push(`Missing file in BUILD.gn for ${gnVariable}: ` + file);
}
}
return errors;
}
function selectGNLines(startLine, endLine, linesToCheck = gnLines) {
const lines = linesToCheck.map(line => line.trim());
const startIndex = lines.indexOf(startLine);
if (startIndex === -1) {
return [];
}
const endIndex = lines.indexOf(endLine, startIndex);
if (endIndex === -1) {
return [];
}
return lines.slice(startIndex + 1, endIndex);
}
function main() {
const errors = [
...checkNonAutostartNonRemoteModules(),
...checkAllDevToolsFiles(),
...checkDevtoolsModuleEntrypoints(),
];
if (errors.length) {
console.log('DevTools BUILD.gn checker detected errors!');
console.log(`There's an issue with: ${gnPath}`);
console.log(errors.join('\n'));
process.exit(1);
}
console.log('DevTools BUILD.gn checker passed');
}
main();