mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-05 03:21:16 +08:00
This reverts commit2b4a9df2d9. Reason for revert: subsequent presubmit uploads should be fixed now. Original change's description: > Revert "Reland "Update stylelint to 14.0.1"" > > This reverts commitf2ea2c940d. > > Reason for revert: https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8831129368825517985/overview > > Original change's description: > > Reland "Update stylelint to 14.0.1" > > > > This reverts commit6c0f161c95. > > > > Reason for revert: the prerequisite CL (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703) has landed > > > > Original change's description: > > > Revert "Update stylelint to 14.0.1" > > > > > > This reverts commit1e08ee816b. > > > > > > Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview > > > > > > Original change's description: > > > > Update stylelint to 14.0.1 > > > > > > > > This also upgrades PostCSS to 8.3.11. > > > > > > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration > > > > R=szuend@chromium.org > > > > > > > > Bug: none > > > > Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541 > > > > Reviewed-by: Simon Zünd <szuend@chromium.org> > > > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> > > > > > > Bug: none > > > Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399 > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Owners-Override: Alex Rudenko <alexrudenko@chromium.org> > > > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> > > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration > > > > Bug: none > > Change-Id: If132a67ee4253d27114caedd66c5ee61c774a6c7 > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264206 > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> > > Reviewed-by: Simon Zünd <szuend@chromium.org> > > Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> > > Bug: none > Change-Id: Idc6c9f5cc1e225c752799461eb0344e94b4ad1e5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264222 > Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration Bug: none Change-Id: I609941d48b46bfcf454b03dcc75a76d460fbe674 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264223 Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
80 lines
2.1 KiB
JavaScript
80 lines
2.1 KiB
JavaScript
'use strict';
|
|
|
|
const validateOptions = require('./utils/validateOptions');
|
|
const { isRegExp, isString } = require('./utils/validateTypes');
|
|
|
|
/**
|
|
* @typedef {import('stylelint').PostcssResult} PostcssResult
|
|
* @typedef {import('stylelint').DisableOptions} DisableOptions
|
|
* @typedef {import('stylelint').DisablePropertyName} DisablePropertyName
|
|
* @typedef {import('stylelint').StylelintPostcssResult} StylelintPostcssResult
|
|
*/
|
|
|
|
/**
|
|
* Validates that the stylelint config for `result` has a valid disable field
|
|
* named `field`, and returns the result in normalized form as well as a
|
|
* `StylelintPostcssResult` for convenience.
|
|
*
|
|
* Returns `null` if no disables should be reported, and automatically reports
|
|
* an invalid configuration. If this returns non-`null`, it guarantees that
|
|
* `result._postcssResult` is defined as well.
|
|
*
|
|
* @param {PostcssResult | undefined} result
|
|
* @param {DisablePropertyName} field
|
|
* @return {[boolean, Required<DisableOptions>, StylelintPostcssResult] | null}
|
|
*/
|
|
module.exports = function (result, field) {
|
|
// Files with `CssSyntaxError`s don't have `_postcssResult`s.
|
|
if (!result) return null;
|
|
|
|
const stylelintResult = result.stylelint;
|
|
|
|
// Files with linting errors may not have configs associated with them.
|
|
if (!stylelintResult.config) return null;
|
|
|
|
const rawSettings = stylelintResult.config[field];
|
|
|
|
/** @type {boolean} */
|
|
let enabled;
|
|
/** @type {DisableOptions} */
|
|
let options;
|
|
|
|
if (Array.isArray(rawSettings)) {
|
|
enabled = rawSettings[0];
|
|
options = rawSettings[1] || {};
|
|
} else {
|
|
enabled = rawSettings || false;
|
|
options = {};
|
|
}
|
|
|
|
const validOptions = validateOptions(
|
|
result,
|
|
field,
|
|
{
|
|
actual: enabled,
|
|
possible: [true, false],
|
|
},
|
|
{
|
|
actual: options,
|
|
possible: {
|
|
except: [isString, isRegExp],
|
|
},
|
|
},
|
|
);
|
|
|
|
if (!validOptions) return null;
|
|
|
|
// If the check is disabled with no exceptions, there's no reason to run
|
|
// it at all.
|
|
if (!enabled && !options.except) return null;
|
|
|
|
return [
|
|
enabled,
|
|
{
|
|
except: options.except || [],
|
|
severity: options.severity || stylelintResult.config.defaultSeverity || 'error',
|
|
},
|
|
stylelintResult,
|
|
];
|
|
};
|