Mathias Bynens
fc21799269
This reverts commit 759a1364c7.
Reason for revert: broke the tree https://ci.chromium.org/p/devtools-frontend/builders/ci/DevTools%20Linux/508
Original change's description:
> Use 1000 not 1024 for kB and MB calculations
>
> This removes the usage of the number 1024 for the calculation of kB and
> MB values. Instead the correct value of 1000 is used.
> The changes mostly affect the file/transfer size values seen in the
> network tab (screenshot: https://imgur.com/a/cDqxScS).
>
> Bug: chromium:1035309
> Change-Id: I2b3e811496f5c99b7b2d77a66834c242f0620df2
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2056480
> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
> Reviewed-by: Mathias Bynens <mathias@chromium.org>
TBR=mathias@chromium.org,wolfi@chromium.org
Change-Id: I69a34847e838a83e1795f316e782870a7fc42d8e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1035309
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2060493
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
DevTools Scripts
Development workflow scripts
These are scripts that can be useful to run independently as you're working on Chrome DevTools front-end.
The newer scripts such as for testing and hosted mode are written in Node.js, which has become the standard toolchain for web apps. The older scripts such as building (e.g. bundling and minifying) are written in Python, which has first-class support in Chromium's infrastructure.
Overview
Folders
- build - Python package for generating DevTools debug and release mode
- chrome_debug_launcher - automagically finds Chrome Canary and launches it with debugging flags (e.g. remote debugging port)
- closure - see section on Closure Compiler below
- gulp - experimental build process written in node.js & gulp to remove the dependency on Chromium-specific build tools (i.e. gn and ninja)
- hosted_mode - run DevTools on a localhost development server
- jsdoc_validator - enforces the use of Closure type annotations
Python Scripts
- compile_frontend.py - runs closure compiler to do static type analysis
- Note: the compiled outputs are not actually used to run DevTools
- lint_javascript.py - run eslint
- optimize_svg_images.py - manually run when changing svg images
Node.js scripts
The easiest way to run the node.js scripts is to use npm run which displays all the commands. For more information on the specific npm run commands, take a look at the primary devtools front-end readme (../readme.md).
Closure
DevTools manually rolls the closure compiler to ./closure. If you manually roll closure compiler, you will need to re-generate the closure_runner (in ./closure) and jsdoc_validator custom jars using the python scripts in their respective directory.