mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-06 20:11:38 +08:00
Mandy Chen
1e9d87b8f2
Since the current localization system uses a unique ID for each string that is calculated based on the the md5 hash of the string, each string in the grdp files needs to be unique. However, there are strings in the frontend that appear multiple times. When such strings are moved across folders, sometimes a seemingly random grdp file is changed by the autofix script. (See https://crrev.com/c/1683826 for an example) This CL introduces shared_strings.grdp, a file dedicated for strings that are shared across folders/grdp files. Instead of putting these strings in the grdp files that come first when sorted alphabetically, they live in shared_strings.grdp and have common descriptions among all instances of such strings. This way if shared strings need to be moved, it's more clear what's going on. Note that this CL contains a lot of changes that are generated automatically (e.g. shared strings are removed from their current locations), so here's the list of actual changes that need to be reviewed: * shared_strings.grdp file is added to front_end/langpacks and front_end/langpacks/ devtools_ui_strings.grd * path to shared_strings.grdp is added to scripts/localization_utils/localization_utils.js * in scripts/localization_utils/check_localized_strings.js, the parser marks strings that appear more than once as shared and set the target grdp file to be shared_strings.grdp * shared_strings.grdp file is checked by scripts/check_localizability.js for localizability violations * shared_strings.grdp messages have common descriptions added Bug: 941561 Change-Id: I00db23854656509f2f03988e70adc0109b6e09d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800918 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Original-Commit-Position: refs/heads/master@{#697667} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: d10bf7c5a97cf9184866c1117935c199bacf7ff3
33 lines
1.8 KiB
XML
33 lines
1.8 KiB
XML
<?xml version="1.0" encoding="utf-8"?>
|
|
<grit-part>
|
|
<message name="IDS_DEVTOOLS_025502db49a6cf61a8245998129bd973" desc="Deletion text in Changes View of the Changes tab">
|
|
<ph name="DELETIONS">$1s<ex>2</ex></ph> deletions (-)
|
|
</message>
|
|
<message name="IDS_DEVTOOLS_5c2892cb638ec999fe22612587cd4a00" desc="Text in Changes View of the Changes tab">
|
|
No changes
|
|
</message>
|
|
<message name="IDS_DEVTOOLS_70c85e43e99bc0cfcbb656123306eb19" desc="Insertion text in Changes View of the Changes tab">
|
|
<ph name="INSERTIONS">$1s<ex>1</ex></ph> insertion (+),
|
|
</message>
|
|
<message name="IDS_DEVTOOLS_af2c230293677261fe33ba6d3fbf02e3" desc="Insertion text in Changes View of the Changes tab">
|
|
<ph name="INSERTIONS">$1s<ex>2</ex></ph> insertions (+),
|
|
</message>
|
|
<message name="IDS_DEVTOOLS_c112bb3542e98308d12d5ecb10a67abc" desc="Title of the 'Changes' tool in the bottom drawer">
|
|
Changes
|
|
</message>
|
|
<message name="IDS_DEVTOOLS_c73e4e53c15d9971d9293fcff6c0d8c0" desc="Text in Changes View of the Changes tab">
|
|
( … Skipping <ph name="LINES_LENGTH___PADDINGLINES____">$1d<ex>2</ex></ph> matching lines … )
|
|
</message>
|
|
<message name="IDS_DEVTOOLS_ca012662d53a8bde28b4d82722aaff7e" desc="The UI destination when right clicking an item that can be revealed">
|
|
Changes drawer
|
|
</message>
|
|
<message name="IDS_DEVTOOLS_df5f7764a0991b372d30c55eb57f6a55" desc="Tooltip text that appears when hovering over the largeicon undo button in the Changes View of the Changes tab">
|
|
Revert all changes
|
|
</message>
|
|
<message name="IDS_DEVTOOLS_e0e5ea9203300d2eb8ced39dd88c214e" desc="Deletion text in Changes View of the Changes tab">
|
|
<ph name="DELETIONS">$1s<ex>1</ex></ph> deletion (-)
|
|
</message>
|
|
<message name="IDS_DEVTOOLS_f550ec70278cc72604795d91ff8dcd30" desc="Text in Changes View of the Changes tab">
|
|
Binary data
|
|
</message>
|
|
</grit-part> |