mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-05 11:31:31 +08:00
Paul Lewis
75090cfd93
This is a reland of 4df552c652
Original change's description:
> Updates node_modules and update script
>
> Change-Id: I3fcf49bc416301a030d298cfc48c448bfeba4335
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1878808
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Change-Id: I97d1442c21420488fadde3f17f67cd4e3b959be6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1880030
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
137 lines
4.3 KiB
Python
137 lines
4.3 KiB
Python
# Copyright 2019 The Chromium Authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
"""
|
|
Helper to manage DEPS.
|
|
"""
|
|
|
|
import os
|
|
import os.path as path
|
|
import subprocess
|
|
import devtools_paths
|
|
import shutil
|
|
import json
|
|
|
|
# List all DEPS here.
|
|
DEPS = {
|
|
"@types/chai": "4.2.0",
|
|
"@types/mocha": "5.2.7",
|
|
"chai": "4.2.0",
|
|
"escodegen": "1.12.0",
|
|
"eslint": "6.0.1",
|
|
"esprima": "git+https://git@github.com/ChromeDevTools/esprima.git#4d0f0e18bd8d3731e5f931bf573af3394cbf7cbe",
|
|
"handlebars": "^4.3.1",
|
|
"karma": "4.2.0",
|
|
"karma-chai": "0.1.0",
|
|
"karma-chrome-launcher": "3.1.0",
|
|
"karma-coverage-istanbul-instrumenter": "^1.0.1",
|
|
"karma-coverage-istanbul-reporter": "^2.1.0",
|
|
"karma-mocha": "1.3.0",
|
|
"karma-typescript": "4.1.1",
|
|
"mocha": "6.2.0",
|
|
"rollup": "^1.23.1",
|
|
"typescript": "3.5.3"
|
|
}
|
|
|
|
|
|
def popen(arguments, cwd=None):
|
|
return subprocess.Popen(arguments, cwd=cwd, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
|
|
|
|
|
|
def clean_node_modules():
|
|
# Clean the node_modules folder first. That way only the packages listed above
|
|
# (and their deps) are installed.
|
|
try:
|
|
shutil.rmtree(path.realpath(devtools_paths.node_modules_path()))
|
|
except OSError as err:
|
|
print('Error removing node_modules: %s, %s' % (err.filename, err.strerror))
|
|
|
|
|
|
def strip_private_fields():
|
|
# npm adds private fields which need to be stripped.
|
|
pattern = path.join(devtools_paths.node_modules_path(), 'package.json')
|
|
packages = []
|
|
for root, dirnames, filenames in os.walk(devtools_paths.node_modules_path()):
|
|
for filename in filter(lambda f: f == 'package.json', filenames):
|
|
packages.append(path.join(root, filename))
|
|
|
|
for pkg in packages:
|
|
with open(pkg, 'r+') as pkg_file:
|
|
prop_removal_count = 0
|
|
try:
|
|
pkg_data = json.load(pkg_file)
|
|
|
|
# Remove anything that begins with an underscore, as these are
|
|
# the private fields in a package.json
|
|
for key in pkg_data.keys():
|
|
if key.find(u'_') == 0:
|
|
pkg_data.pop(key)
|
|
prop_removal_count = prop_removal_count + 1
|
|
|
|
pkg_file.truncate(0)
|
|
pkg_file.seek(0)
|
|
json.dump(pkg_data, pkg_file, indent=2, sort_keys=True)
|
|
print("(%s): %s" % (prop_removal_count, pkg))
|
|
except:
|
|
print('Unable to fix: %s' % pkg)
|
|
return True
|
|
|
|
return False
|
|
|
|
|
|
def remove_package_json_entries():
|
|
with open(devtools_paths.package_json_path(), 'r+') as pkg_file:
|
|
try:
|
|
pkg_data = json.load(pkg_file)
|
|
|
|
# Remove the dependencies and devDependencies from the root package.json
|
|
# so that they can't be used to overwrite the node_modules managed by this file.
|
|
for key in pkg_data.keys():
|
|
if key.find(u'dependencies') == 0 or key.find(u'devDependencies') == 0:
|
|
pkg_data.pop(key)
|
|
|
|
pkg_file.truncate(0)
|
|
pkg_file.seek(0)
|
|
json.dump(pkg_data, pkg_file, indent=2, sort_keys=True)
|
|
except:
|
|
print('Unable to fix: %s' % pkg)
|
|
return True
|
|
return False
|
|
|
|
|
|
def install_deps():
|
|
clean_node_modules()
|
|
|
|
exec_command = ['npm', 'install', '--save-dev']
|
|
for pkg, version in DEPS.items():
|
|
# For git URLs we append the url rather than package@version, since the package@version
|
|
# formulation doesn't work.
|
|
if version.find(u'git+') == 0:
|
|
exec_command.append('%s' % version)
|
|
else:
|
|
exec_command.append('%s@%s' % (pkg, version))
|
|
|
|
errors_found = False
|
|
npm_proc_result = subprocess.check_call(exec_command, cwd=devtools_paths.root_path())
|
|
if npm_proc_result != 0:
|
|
errors_found = True
|
|
|
|
# If npm fails, bail here, otherwise attempt to strip private fields.
|
|
if errors_found:
|
|
return True
|
|
|
|
errors_found = strip_private_fields()
|
|
if errors_found:
|
|
return True
|
|
|
|
errors_found = remove_package_json_entries()
|
|
return errors_found
|
|
|
|
|
|
npm_errors_found = install_deps()
|
|
|
|
if npm_errors_found:
|
|
print('npm installation failed')
|
|
else:
|
|
print('npm installation successful')
|