Peter Marshall
d74ef01edb
Rather than hardcode the port to use, use port 0 which requests any free port from the OS. We report the port we end up using to the caller over IPC, if an IPC channel was opened by the caller. We wait for the port to get reported before starting the chrome instance. Previously we started the hosted mode server and then started chrome without waiting for it to start. This is probably fine in most situations because chrome takes a while to start and we need to do extra setup there, so we have a long time before the server needs to respond. For parallel test mode, we need to make sure we start the server on a free port. This also makes the mocha runner more robust to failures e.g. if we accidentally leave the server running and the port is taken. This doesn't slow down the startup time of the e2e test runner at all, according to timing of local runs. Bug: 1101784 Change-Id: Ibb14d5a177ba5f9e257743824770bff3d5ccb033 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2285124 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
DevTools Scripts
Development workflow scripts
These are scripts that can be useful to run independently as you're working on Chrome DevTools front-end.
The newer scripts such as for testing and hosted mode are written in Node.js, which has become the standard toolchain for web apps. The older scripts such as building (e.g. bundling and minifying) are written in Python, which has first-class support in Chromium's infrastructure.
Overview
Folders
- build - Python package for generating DevTools debug and release mode
- chrome_debug_launcher - automagically finds Chrome Canary and launches it with debugging flags (e.g. remote debugging port)
- closure - see section on Closure Compiler below
- gulp - experimental build process written in node.js & gulp to remove the dependency on Chromium-specific build tools (i.e. gn and ninja)
- hosted_mode - run DevTools on a localhost development server
- jsdoc_validator - enforces the use of Closure type annotations
Python Scripts
- compile_frontend.py - runs closure compiler to do static type analysis
- Note: the compiled outputs are not actually used to run DevTools
- lint_javascript.py - run eslint
- optimize_svg_images.py - manually run when changing svg images
Node.js scripts
The easiest way to run the node.js scripts is to use npm run which displays all the commands. For more information on the specific npm run commands, take a look at the primary devtools front-end readme (../readme.md).
Closure
DevTools manually rolls the closure compiler to ./closure. If you manually roll closure compiler, you will need to re-generate the closure_runner (in ./closure) and jsdoc_validator custom jars using the python scripts in their respective directory.