mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-02 18:11:04 +08:00
This makes sure that whenever `npm run install-deps` is run, the .clang-format file is also written (as we don't want clang-format to format the node_modules folder). R=aerotwist@chromium.org,jacktfranklin@chromium.org Change-Id: I4d3d1f7241833f622575ae237792fbacdc6e02ea Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2112366 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
225 lines
6.4 KiB
Python
225 lines
6.4 KiB
Python
# Copyright 2019 The Chromium Authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
"""
|
|
Helper to manage DEPS.
|
|
"""
|
|
|
|
import os
|
|
import os.path as path
|
|
import json
|
|
import shutil
|
|
import subprocess
|
|
import sys
|
|
|
|
scripts_path = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
|
|
sys.path.append(scripts_path)
|
|
|
|
import devtools_paths
|
|
|
|
LICENSES = [
|
|
"MIT",
|
|
"Apache-2.0",
|
|
"BSD",
|
|
"BSD-2-Clause",
|
|
"BSD-3-Clause",
|
|
"CC0-1.0",
|
|
"CC-BY-3.0",
|
|
"ISC",
|
|
]
|
|
|
|
# List all DEPS here.
|
|
DEPS = {
|
|
"@types/chai": "4.2.0",
|
|
"@types/filesystem": "0.0.29",
|
|
"@types/mocha": "5.2.7",
|
|
"@types/puppeteer": "2.0.0",
|
|
"@typescript-eslint/parser": "2.16.0",
|
|
"@typescript-eslint/eslint-plugin": "2.16.0",
|
|
"chai": "4.2.0",
|
|
"escodegen": "1.12.0",
|
|
"eslint": "6.0.1",
|
|
"eslint-plugin-mocha": "6.2.2",
|
|
"eslint-plugin-rulesdir": "0.1.0",
|
|
"esprima": "git+https://git@github.com/ChromeDevTools/esprima.git#4d0f0e18bd8d3731e5f931bf573af3394cbf7cbe",
|
|
"handlebars": "4.3.1",
|
|
"istanbul-diff": "2.0.0",
|
|
"karma": "4.2.0",
|
|
"karma-chai": "0.1.0",
|
|
"karma-chrome-launcher": "3.1.0",
|
|
"karma-coverage-istanbul-instrumenter": "1.0.1",
|
|
"karma-coverage-istanbul-reporter": "2.1.0",
|
|
"karma-mocha": "1.3.0",
|
|
"karma-sourcemap-loader": "0.3.0",
|
|
"karma-typescript": "4.1.1",
|
|
"license-checker": "25.0.1",
|
|
"mocha": "6.2.0",
|
|
"puppeteer": "2.0.0",
|
|
"recast": "0.18.2",
|
|
"rimraf": "3.0.2",
|
|
"rollup": "1.23.1",
|
|
"typescript": "3.8.3",
|
|
"yargs": "15.0.2"
|
|
}
|
|
|
|
def exec_command(cmd):
|
|
try:
|
|
cmd_proc_result = subprocess.check_call(cmd, cwd=devtools_paths.root_path())
|
|
except Error as error:
|
|
print(error.output)
|
|
return True
|
|
|
|
return False
|
|
|
|
|
|
def ensure_licenses():
|
|
cmd = [
|
|
devtools_paths.node_path(),
|
|
devtools_paths.license_checker_path(),
|
|
'--onlyAllow',
|
|
('%s' % (';'.join(LICENSES)))
|
|
]
|
|
|
|
return exec_command(cmd)
|
|
|
|
|
|
def strip_private_fields():
|
|
# npm adds private fields which need to be stripped.
|
|
pattern = path.join(devtools_paths.node_modules_path(), 'package.json')
|
|
packages = []
|
|
for root, dirnames, filenames in os.walk(devtools_paths.node_modules_path()):
|
|
for filename in filter(lambda f: f == 'package.json', filenames):
|
|
packages.append(path.join(root, filename))
|
|
|
|
for pkg in packages:
|
|
with open(pkg, 'r+') as pkg_file:
|
|
prop_removal_count = 0
|
|
try:
|
|
pkg_data = json.load(pkg_file)
|
|
|
|
# Remove anything that begins with an underscore, as these are
|
|
# the private fields in a package.json
|
|
for key in pkg_data.keys():
|
|
if key.find(u'_') == 0:
|
|
pkg_data.pop(key)
|
|
prop_removal_count = prop_removal_count + 1
|
|
|
|
pkg_file.truncate(0)
|
|
pkg_file.seek(0)
|
|
json.dump(pkg_data, pkg_file, indent=2, sort_keys=True, separators=(',', ': '))
|
|
print("(%s): %s" % (prop_removal_count, pkg))
|
|
except:
|
|
print('Unable to fix: %s' % pkg)
|
|
return True
|
|
|
|
return False
|
|
|
|
|
|
def install_missing_deps():
|
|
with open(devtools_paths.package_lock_json_path(), 'r+') as pkg_lock_file:
|
|
try:
|
|
pkg_lock_data = json.load(pkg_lock_file)
|
|
existing_deps = pkg_lock_data[u'dependencies']
|
|
new_deps = []
|
|
|
|
# Find any new DEPS and add them in.
|
|
for dep, version in DEPS.items():
|
|
if not dep in existing_deps or not existing_deps[dep]['version'] == version:
|
|
new_deps.append("%s@%s" % (dep, version))
|
|
|
|
# Now install.
|
|
if len(new_deps) > 0:
|
|
cmd = ['npm', 'install', '--save-dev']
|
|
cmd.extend(new_deps)
|
|
return exec_command(cmd)
|
|
|
|
except Exception as exception:
|
|
print('Unable to install: %s' % exception)
|
|
return True
|
|
|
|
return False
|
|
|
|
|
|
def append_package_json_entries():
|
|
with open(devtools_paths.package_json_path(), 'r+') as pkg_file:
|
|
try:
|
|
pkg_data = json.load(pkg_file)
|
|
|
|
# Replace the dev deps.
|
|
pkg_data[u'devDependencies'] = DEPS
|
|
|
|
pkg_file.truncate(0)
|
|
pkg_file.seek(0)
|
|
json.dump(pkg_data, pkg_file, indent=2, sort_keys=True, separators=(',', ': '))
|
|
|
|
except:
|
|
print('Unable to fix: %s' % sys.exc_info()[0])
|
|
return True
|
|
return False
|
|
|
|
|
|
def remove_package_json_entries():
|
|
with open(devtools_paths.package_json_path(), 'r+') as pkg_file:
|
|
try:
|
|
pkg_data = json.load(pkg_file)
|
|
|
|
# Remove the dependencies and devDependencies from the root package.json
|
|
# so that they can't be used to overwrite the node_modules managed by this file.
|
|
for key in pkg_data.keys():
|
|
if key.find(u'dependencies') == 0 or key.find(u'devDependencies') == 0:
|
|
pkg_data.pop(key)
|
|
|
|
pkg_file.truncate(0)
|
|
pkg_file.seek(0)
|
|
json.dump(pkg_data, pkg_file, indent=2, sort_keys=True, separators=(',', ': '))
|
|
except:
|
|
print('Unable to fix: %s' % pkg)
|
|
return True
|
|
return False
|
|
|
|
|
|
def addClangFormat():
|
|
with open(path.join(devtools_paths.node_modules_path(), '.clang-format'), 'w+') as clang_format_file:
|
|
try:
|
|
clang_format_file.write('DisableFormat: true')
|
|
except:
|
|
print('Unable to write .clang-format file')
|
|
return True
|
|
return False
|
|
|
|
|
|
def install_deps():
|
|
for (name, version) in DEPS.items():
|
|
if (version.find(u'^') == 0):
|
|
print('Versions must be locked to a specific version; remove ^ from the start of the version.')
|
|
return True
|
|
|
|
if append_package_json_entries():
|
|
return True
|
|
|
|
if install_missing_deps():
|
|
return True
|
|
|
|
# Run the CI version of npm, which prevents updates to the versions of modules.
|
|
if exec_command(['npm', 'ci']):
|
|
return True
|
|
|
|
if strip_private_fields():
|
|
return True
|
|
|
|
if remove_package_json_entries():
|
|
return True
|
|
|
|
if addClangFormat():
|
|
return True
|
|
|
|
return ensure_licenses()
|
|
|
|
|
|
npm_errors_found = install_deps()
|
|
|
|
if npm_errors_found:
|
|
print('npm installation failed')
|
|
else:
|
|
print('npm installation successful')
|