Mandy Chen
d97200bd72
This patch adds a localizability check to the presubmit script that reports errors for empty descriptions, after https://crrev.com/c/1688716 adds auto- generated descriptions. Example error messages: third_party/blink/renderer/devtools/front_end/accessibility/accessibility_strings.grdp Line 36: missing description for message with the name "IDS_DEVTOOLS_185551542d4a950d6ed4a90e0875dfde" third_party/blink/renderer/devtools/front_end/animation/animation_strings.grdp Line 10: missing <ex> in <ph> tag with the name "BUTTON_TEXTCONTENT" This patch also improves error reporting by changing full file path to partial path from src/ so that it's more consistent with the presubmit error style. Note: there may be new strings added without a description and/or placeholder example while this patch is on review. In that case I will fix them so the check can be enabled without any problem. Bug: 941561 Change-Id: If609d234b67acb76dfd9c66e2f8880d9875034cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693028 Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#681975} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 1404bfcfd225f2963874e37299d890b1f3119e72
DevTools Scripts
Development workflow scripts
These are scripts that can be useful to run independently as you're working on Chrome DevTools front-end.
The newer scripts such as for testing and hosted mode are written in Node.js, which has become the standard toolchain for web apps. The older scripts such as building (e.g. bundling and minifying) are written in Python, which has first-class support in Chromium's infrastructure.
Overview
Folders
- build - Python package for generating DevTools debug and release mode
- chrome_debug_launcher - automagically finds Chrome Canary and launches it with debugging flags (e.g. remote debugging port)
- closure - see section on Closure Compiler below
- gulp - experimental build process written in node.js & gulp to remove the dependency on Chromium-specific build tools (i.e. gn and ninja)
- hosted_mode - run DevTools on a localhost development server
- jsdoc_validator - enforces the use of Closure type annotations
- local_node - installs a local runtime of node.js
Python Scripts
- compile_frontend.py - runs closure compiler to do static type analysis
- Note: the compiled outputs are not actually used to run DevTools
- lint_javascript.py - run eslint
- optimize_svg_images.py - manually run when changing svg images
Node.js scripts
The easiest way to run the node.js scripts is to use npm run which displays all the commands. For more information on the specific npm run commands, take a look at the primary devtools front-end readme (../readme.md).
Closure
DevTools manually rolls the closure compiler to ./closure. If you manually roll closure compiler, you will need to re-generate the closure_runner (in ./closure) and jsdoc_validator custom jars using the python scripts in their respective directory.