mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-01 09:47:56 +08:00
Paul Lewis
6c0b15e0dc
We've found that files missed from the GRD cause issues in Chromium, since it looks to the GRD/pak in order to serve the DevTools frontend. Standalone builds of the DevTools frontend (as well as using --custom-devtools-frontend in Chromium) do not present with the issue, since in those cases the files are loaded directly from disk (rather than via the GRD/pak file). This CL introduces two new lists: a global list of files required for the Release build (is_debug=false) of Chromium, and a second list of files required for the Debug build (is_debug=true). These lists are cross-referenced to ensure no overlap, thus in Release we use the first list, and in Debug we use both. In the root BUILD.gn we now check that files that are inputted to the GRD builder action map exactly to the list of files expected for the GRD, and any mismatch causes a build failure. R=danno@chromium.org DISABLE_THIRD_PARTY_CHECK=Adding owners and file at the same time Change-Id: I5e215eb5dc249123ab07210baa3eeb00da225410 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2324586 Commit-Queue: Paul Lewis <aerotwist@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Paul Lewis <aerotwist@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
22 lines
880 B
Plaintext
22 lines
880 B
Plaintext
file://ENG_REVIEW_OWNERS
|
|
|
|
per-file .*=file://INFRA_OWNERS
|
|
per-file AUTHORS=file://COMMON_OWNERS
|
|
per-file BUILD.gn=file://INFRA_OWNERS
|
|
per-file DEPS=file://INFRA_OWNERS
|
|
per-file PRESUBMIT.py=file://INFRA_OWNERS
|
|
per-file README.md=file://COMMON_OWNERS
|
|
per-file WATCHLISTS=file://INFRA_OWNERS
|
|
per-file all_devtools_files.gni=file://COMMON_OWNERS
|
|
per-file all_devtools_modules.gni=file://COMMON_OWNERS
|
|
per-file devtools_grd_files.gni=file://COMMON_OWNERS
|
|
per-file codereview.settings=file://INFRA_OWNERS
|
|
per-file devtools_image_files.gni=file://COMMON_OWNERS
|
|
per-file devtools_module_entrypoints.gni=file://COMMON_OWNERS
|
|
per-file htaccess=file://INFRA_OWNERS
|
|
per-file karma.conf.json=file://INFRA_OWNERS
|
|
per-file package-lock.json=file://INFRA_OWNERS
|
|
per-file package.json=file://INFRA_OWNERS
|
|
per-file tsconfig.base.json=file://INFRA_OWNERS
|
|
per-file tsconfig.json=file://INFRA_OWNERS
|