mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-01 17:57:36 +08:00
Michael Liao
e18b2c30ca
Issue:
- focus is not clearly visible on the delete button for live expressions
Changes:
- changed the delete button to 'dt-close-button' (the one that tabbed panes use)
- made screen reader labels more descriptive
- From: "Remove expression"
- To: "Remove blank expression" or "Remove expression: {expression}"
Before: https://imgur.com/DjqAU9y
After: https://imgur.com/tfCDnqu
Bug: 1133344
Change-Id: Ic41d218316a701bf224ce61094a5765806d2eec7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2438200
Reviewed-by: Songtao Xia <soxia@microsoft.com>
Reviewed-by: Jack Lynch <jalyn@microsoft.com>
Commit-Queue: Michael Liao <michael.liao@microsoft.com>
96 lines
1.9 KiB
CSS
96 lines
1.9 KiB
CSS
/*
|
|
* Copyright 2018 The Chromium Authors. All rights reserved.
|
|
* Use of this source code is governed by a BSD-style license that can be
|
|
* found in the LICENSE file.
|
|
*/
|
|
|
|
.close-button {
|
|
position: absolute;
|
|
top: 7px;
|
|
left: 5px;
|
|
}
|
|
|
|
.console-pins {
|
|
max-height: 200px;
|
|
overflow-y: auto;
|
|
background: var(--toolbar-bg-color);
|
|
|
|
--error-background-color: hsl(0deg 100% 97%);
|
|
--error-border-color: hsl(0deg 100% 92%);
|
|
--error-text-color: red;
|
|
}
|
|
|
|
.console-pins:not(:empty) {
|
|
border-bottom: 1px solid var(--divider-color);
|
|
}
|
|
|
|
:host-context(.-theme-with-dark-background) .console-pins {
|
|
--error-background-color: hsl(0deg 100% 8%);
|
|
--error-border-color: rgb(92 0 0);
|
|
--error-text-color: hsl(0deg 100% 75%);
|
|
}
|
|
|
|
.console-pin {
|
|
position: relative;
|
|
user-select: text;
|
|
flex: none;
|
|
padding: 2px 0 6px 24px;
|
|
}
|
|
|
|
.console-pin:not(:last-child) {
|
|
border-bottom: 1px solid #e4e4e4;
|
|
}
|
|
|
|
.console-pin.error-level:not(:focus-within) {
|
|
background-color: var(--error-background-color);
|
|
color: var(--error-text-color);
|
|
}
|
|
|
|
.console-pin:not(:last-child).error-level:not(:focus-within) {
|
|
border-top: 1px solid var(--error-border-color);
|
|
border-bottom: 1px solid var(--error-border-color);
|
|
margin-top: -1px;
|
|
}
|
|
|
|
.console-pin-name {
|
|
margin-left: -4px;
|
|
margin-bottom: 1px;
|
|
height: auto;
|
|
}
|
|
|
|
.console-pin-name,
|
|
.console-pin-preview {
|
|
width: 100%;
|
|
overflow: hidden;
|
|
text-overflow: ellipsis;
|
|
white-space: nowrap;
|
|
min-height: 13px;
|
|
}
|
|
|
|
.console-delete-pin {
|
|
position: absolute;
|
|
top: 8px;
|
|
left: 8px;
|
|
opacity: 70%;
|
|
cursor: pointer;
|
|
}
|
|
|
|
.console-delete-pin:hover,
|
|
.console-delete-pin:focus-visible {
|
|
opacity: 100%;
|
|
}
|
|
|
|
:host-context(.-theme-with-dark-background) .console-delete-pin {
|
|
filter: brightness(2);
|
|
}
|
|
|
|
.console-pin-name:focus-within {
|
|
background: #fff;
|
|
box-shadow: var(--focus-ring-active-shadow) inset;
|
|
}
|
|
|
|
.console-pin:focus-within .console-pin-preview,
|
|
.console-pin-name:not(:focus-within):not(:hover) {
|
|
opacity: 60%;
|
|
}
|