mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-02 18:11:04 +08:00
Jack Franklin
187489319e
This reverts commit8794ac6b44. Reason for revert: Fixed issue with missing file that caused browser tests to fail. Original change's description: > Revert "Ship new ElementsBreadcrumbs to production" > > This reverts commitd8d96d5f0a. > > Reason for revert: Breaks browser_tests: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874686472852976032/+/steps/browser_tests/0/logs/Deterministic_failure:_SitePerProcessDevToolsSanityTest.InspectElement__status_FAILURE_/0 > > Confirmed locally on a Linux Debug build that this is the offending CL. > > Original change's description: > > Ship new ElementsBreadcrumbs to production > > > > This CL ships the new elements breadcrumbs component to production, > > replacing the old legacy breadcrumbs with the new custom element that > > we've built to replace it. > > > > Note that I haven't renamed the file from `NewElementsBreadcrumbs`. I wanted to > > keep the diff on this CL clear and easy to follow. I plan to follow this up > > with another CL that does the renaming. > > > > Light mode & dark mode screenshots: https://imgur.com/a/UyF4ktY > > > > Change-Id: I5c3df09456101ce03072f3eeb27f6a1c568cf9c7 > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2297395 > > Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> > > Reviewed-by: Paul Lewis <aerotwist@chromium.org> > > Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org> > > TBR=aerotwist@chromium.org,tvanderlippe@chromium.org,jacktfranklin@chromium.org > > Change-Id: I62be4e9e3bd1fc328733ded3fff377ffd50e2d81 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2300491 > Commit-Queue: Simon Zünd <szuend@chromium.org> > Reviewed-by: Simon Zünd <szuend@chromium.org> TBR=aerotwist@chromium.org,szuend@chromium.org,tvanderlippe@chromium.org,jacktfranklin@chromium.org Change-Id: Iae6aa0ce84a57312a29d79344059f887f337c5bb Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2300494 Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
50 lines
1.5 KiB
Plaintext
50 lines
1.5 KiB
Plaintext
# Copyright 2020 The Chromium Authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
import("./vars.gni")
|
|
|
|
template("rollup") {
|
|
assert(defined(invoker.entrypoint),
|
|
"You must define the 'entrypoint' for a rollup target")
|
|
|
|
action(target_name) {
|
|
script = "//third_party/node/node.py"
|
|
|
|
forward_variables_from(invoker,
|
|
[
|
|
"visibility",
|
|
"deps",
|
|
"public_deps",
|
|
])
|
|
|
|
inputs = [
|
|
invoker.entrypoint,
|
|
devtools_location_prepend + "node_modules/rollup/dist/bin/rollup",
|
|
devtools_location_prepend + "front_end/rollup.config.js",
|
|
]
|
|
|
|
args = [
|
|
rebase_path(
|
|
devtools_location_prepend + "node_modules/rollup/dist/bin/rollup",
|
|
root_build_dir),
|
|
|
|
# TODO(crbug.com/1098074): We need to hide warnings that are written stderr,
|
|
# as Chromium does not process the returncode of the subprocess correctly
|
|
# and instead looks if `stderr` is empty.
|
|
"--silent",
|
|
"--plugin",
|
|
"terser",
|
|
"--config",
|
|
rebase_path(devtools_location_prepend + "front_end/rollup.config.js",
|
|
root_build_dir),
|
|
"--input",
|
|
rebase_path(invoker.entrypoint, root_build_dir),
|
|
"--file",
|
|
rebase_path(invoker.output_file_location, root_build_dir),
|
|
]
|
|
|
|
outputs = [ invoker.output_file_location ]
|
|
}
|
|
}
|