mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-09-30 17:27:22 +08:00
Root cause: i18n is designed to work with strings that are declared in a UIStrings object on the SAME file where they are being used. To my best knowledge this is done to improve performance when searching for a translation, but in Devtools there are strings that live in module.json files and are exposed to i18n via a ModuleUIStrings.js file. Fix: There is already a mechanism for this kind of templating in the i18n library which exposes a small subset of translations that match a specific pattern, the fix is to change this pattern to match ModuleUIStrings and to also include this as part of the translation resolution. Change-Id: If44a84a9b5892558bf832e6d08ea36d1a8f4ddd1 Bug: 1136655 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2459638 Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com> Reviewed-by: Simon Zünd <szuend@chromium.org>