mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-11-06 13:19:17 +08:00

Files

T

PhistucK 257ad69b8a Reland "Add a global setting for search as you type"

Change to the original CL:
* Updated `helper.ts` to use `pressKey` utility for summoning the search box. It wasn't been summoned before because `summon` function was using `Control` + `f` instead of `Meta` + `f` in MacOS.

This is a reland of commit b4643a4703

Original change's description:
> Add a global setting for search as you type
>
> Added a global setting to the settings screen and to the command menu
> for enabling search-as-you-type, or requiring Enter for searching,
> in search boxes that support it.
>
> - Added strings, a setting and commands for the new setting.
> - Bailed early on input when the setting is disabled.
> - Tests -
>  - Added general helpers for getting text contents and summoning the
>    search box.
>  - Added elements-panel-specific helpers for the tests.
>  - Made the setting toggle helper accept an optional expected state.
>
> Bug: 1344526
> Change-Id: I75612a54c10d5f40b208084fdbd0ffd7614f7f7c
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3859617
> Auto-Submit: PhistucK Productions <phistuck@gmail.com>
> Commit-Queue: PhistucK Productions <phistuck@gmail.com>
> Reviewed-by: Victor Porof <victorporof@chromium.org>
> Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>

Bug: 1344526
Change-Id: If92d692307a0ac298657ff9ace7df0c887fde1cf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3865397
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Victor Porof <victorporof@chromium.org>
Commit-Queue: Victor Porof <victorporof@chromium.org>