mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-01 09:47:56 +08:00
Throughout this process we learned the following: - The magically generated agents need to be properly exposed on the target, rather than setting them on the TargetBase prototype. - We need to rename the protocol proxy api definitions to use the invoke_ naming, such that we can use structured request bodies. This will allow us to no longer rely on parameter ordering and does not require additional changes to the underlying Closure generated code. - Instead of using a symbol as an index on a different class, use a WeakMap to keep track of the link between the NetworkRequest and the NetworkManager. This breaks the circular dependency and allows us to remove the lookup with the symbol R=aerotwist@chromium.org,jacktfranklin@chromium.org Bug: 1011811 Change-Id: I6cf25533b32793636d970b0a6c108f739d4e757e Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2167868 Reviewed-by: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by: Paul Lewis <aerotwist@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>