mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-09-30 01:07:01 +08:00
We weren't running ESLint on this directory and, as it turns out, there are quite a few linter errors in this folder. R=jacktfranklin@chromium.org Change-Id: Ic6cb9f6ad4858f69114e0c433a954041215b49e2 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2096705 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
185 lines
6.0 KiB
JavaScript
185 lines
6.0 KiB
JavaScript
// Copyright 2017 The Chromium Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
'use strict';
|
|
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
const FRONTEND_PATH = path.resolve(__dirname, '..', 'front_end');
|
|
|
|
const manifestModules = [];
|
|
for (const config
|
|
of ['inspector.json', 'devtools_app.json', 'js_app.json', 'node_app.json', 'shell.json', 'worker_app.json']) {
|
|
manifestModules.push(...require(path.resolve(FRONTEND_PATH, config)).modules);
|
|
}
|
|
|
|
const utils = require('./utils');
|
|
|
|
const gnPath = path.resolve(__dirname, '..', 'BUILD.gn');
|
|
const gnFile = fs.readFileSync(gnPath, 'utf-8');
|
|
const gnLines = gnFile.split('\n');
|
|
|
|
function main() {
|
|
const errors = [
|
|
...checkNonAutostartNonRemoteModules(),
|
|
...checkAllDevToolsFiles(),
|
|
...checkAllDevToolsModules(),
|
|
...checkDevtoolsModuleEntrypoints(),
|
|
];
|
|
if (errors.length) {
|
|
console.log('DevTools BUILD.gn checker detected errors!');
|
|
console.log(`There's an issue with: ${gnPath}`);
|
|
console.log(errors.join('\n'));
|
|
process.exit(1);
|
|
}
|
|
console.log('DevTools BUILD.gn checker passed');
|
|
}
|
|
|
|
main();
|
|
|
|
/**
|
|
* Ensures that generated module files are in the right list in BUILD.gn.
|
|
* This is primarily to avoid remote modules from accidentally getting
|
|
* bundled with the main Chrome binary.
|
|
*/
|
|
function checkNonAutostartNonRemoteModules() {
|
|
const errors = [];
|
|
const gnVariable = 'generated_non_autostart_non_remote_modules';
|
|
const lines = selectGNLines(`${gnVariable} = [`, ']');
|
|
if (!lines.length) {
|
|
return [
|
|
'Could not identify non-autostart non-remote modules in gn file',
|
|
'Please look at: ' + __filename,
|
|
];
|
|
}
|
|
const text = lines.join('\n');
|
|
const modules = manifestModules.filter(m => m.type !== 'autostart' && m.type !== 'remote').map(m => m.name);
|
|
|
|
const missingModules = modules.filter(m => !utils.includes(text, `${m}/${m}_module.js`));
|
|
if (missingModules.length) {
|
|
errors.push(`Check that you've included [${missingModules.join(', ')}] modules in: ` + gnVariable);
|
|
}
|
|
|
|
// e.g. "$resources_out_dir/lighthouse/lighthouse_module.js" => "lighthouse"
|
|
const mapLineToModuleName = line => line.split('/')[2].split('_module')[0];
|
|
|
|
const extraneousModules = lines.map(mapLineToModuleName).filter(module => !utils.includes(modules, module));
|
|
if (extraneousModules.length) {
|
|
errors.push(`Found extraneous modules [${extraneousModules.join(', ')}] in: ` + gnVariable);
|
|
}
|
|
|
|
return errors;
|
|
}
|
|
|
|
/**
|
|
* Ensures that all source files (according to the various module.json files) are
|
|
* listed in BUILD.gn.
|
|
*/
|
|
function checkAllDevToolsFiles() {
|
|
return checkGNVariable('all_devtools_files', moduleJSON => {
|
|
const scripts = moduleJSON.scripts || [];
|
|
const resources = moduleJSON.resources || [];
|
|
return [
|
|
'module.json',
|
|
...scripts,
|
|
...resources,
|
|
];
|
|
});
|
|
}
|
|
|
|
function checkAllDevToolsModules() {
|
|
return checkGNVariable(
|
|
'all_devtools_modules',
|
|
(moduleJSON, folderName) => {
|
|
return (moduleJSON.modules || []).filter(fileName => {
|
|
return fileName !== `${folderName}.js` && fileName !== `${folderName}-legacy.js`;
|
|
});
|
|
},
|
|
buildGNPath => filename => {
|
|
const relativePath = path.normalize(`${buildGNPath}/${filename}`);
|
|
return `"${relativePath}",`;
|
|
});
|
|
}
|
|
|
|
function checkDevtoolsModuleEntrypoints() {
|
|
return checkGNVariable(
|
|
'devtools_module_entrypoints',
|
|
(moduleJSON, folderName) => {
|
|
return (moduleJSON.modules || []).filter(fileName => {
|
|
return fileName === `${folderName}.js` || fileName === `${folderName}-legacy.js`;
|
|
});
|
|
},
|
|
buildGNPath => filename => {
|
|
const relativePath = path.normalize(`${buildGNPath}/${filename}`);
|
|
return `"${relativePath}",`;
|
|
});
|
|
}
|
|
|
|
function checkGNVariable(gnVariable, obtainFiles, obtainRelativePath) {
|
|
const errors = [];
|
|
const excludedFiles = ['axe.js', 'formatter_worker/', 'third_party/lighthouse/'].map(path.normalize);
|
|
const lines = selectGNLines(`${gnVariable} = [`, ']').map(path.normalize);
|
|
if (!lines.length) {
|
|
return [
|
|
`Could not identify ${gnVariable} list in gn file`,
|
|
'Please look at: ' + __filename,
|
|
];
|
|
}
|
|
const gnFiles = new Set(lines);
|
|
let moduleFiles = [];
|
|
|
|
function addModuleFilesForDirectory(moduleJSONPath, buildGNPath, folderName) {
|
|
const moduleJSON = require(moduleJSONPath);
|
|
const files = obtainFiles(moduleJSON, folderName)
|
|
.map(obtainRelativePath && obtainRelativePath(buildGNPath) || relativePathFromBuildGN)
|
|
.filter(file => excludedFiles.every(excludedFile => !file.includes(excludedFile)));
|
|
moduleFiles = moduleFiles.concat(files);
|
|
|
|
function relativePathFromBuildGN(filename) {
|
|
const relativePath = path.normalize(`front_end/${buildGNPath}/${filename}`);
|
|
return `"${relativePath}",`;
|
|
}
|
|
}
|
|
|
|
function traverseDirectoriesForModuleJSONFiles(folderName, buildGNPath) {
|
|
if (!fs.lstatSync(folderName).isDirectory()) {
|
|
return;
|
|
}
|
|
const moduleJSONPath = path.join(folderName, 'module.json');
|
|
if (utils.isFile(moduleJSONPath)) {
|
|
addModuleFilesForDirectory(moduleJSONPath, buildGNPath, path.basename(folderName));
|
|
}
|
|
|
|
fs.readdirSync(folderName).forEach(nestedModuleName => {
|
|
traverseDirectoriesForModuleJSONFiles(
|
|
path.join(folderName, nestedModuleName), `${buildGNPath}/${nestedModuleName}`);
|
|
});
|
|
}
|
|
|
|
fs.readdirSync(FRONTEND_PATH).forEach(moduleName => {
|
|
traverseDirectoriesForModuleJSONFiles(path.join(FRONTEND_PATH, moduleName), moduleName);
|
|
});
|
|
|
|
for (const file of moduleFiles) {
|
|
if (!gnFiles.has(file)) {
|
|
errors.push(`Missing file in BUILD.gn for ${gnVariable}: ` + file);
|
|
}
|
|
}
|
|
|
|
return errors;
|
|
}
|
|
|
|
function selectGNLines(startLine, endLine) {
|
|
const lines = gnLines.map(line => line.trim());
|
|
const startIndex = lines.indexOf(startLine);
|
|
if (startIndex === -1) {
|
|
return [];
|
|
}
|
|
const endIndex = lines.indexOf(endLine, startIndex);
|
|
if (endIndex === -1) {
|
|
return [];
|
|
}
|
|
return lines.slice(startIndex + 1, endIndex);
|
|
}
|