mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-01 01:38:07 +08:00
Major updates to Puppeteer (Chromium roll and updates to types: https://github.com/puppeteer/puppeteer/blob/0b5969dea9048dc34a4d2e109e96c42e8928182c/CHANGELOG.md#800-2021-02-26) and Sinon (unaffected by browser support changes). DISABLE_THIRD_PARTY_CHECK=NPM updates R=jacktfranklin@chromium.org Fixed: 1176642 Change-Id: I419300fc573e8086b4a7b3b6281c81602890f8d0 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2782553 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
63 lines
2.0 KiB
JavaScript
63 lines
2.0 KiB
JavaScript
'use strict';
|
|
|
|
const optionsMatches = require('./utils/optionsMatches');
|
|
const validateDisableSettings = require('./validateDisableSettings');
|
|
|
|
/** @typedef {import('postcss/lib/comment')} PostcssComment */
|
|
/** @typedef {import('stylelint').RangeType} RangeType */
|
|
/** @typedef {import('stylelint').DisableReportRange} DisableReportRange */
|
|
/** @typedef {import('stylelint').StylelintDisableOptionsReport} StylelintDisableOptionsReport */
|
|
|
|
/**
|
|
* @param {import('stylelint').StylelintResult[]} results
|
|
*/
|
|
module.exports = function (results) {
|
|
results.forEach((result) => {
|
|
const settings = validateDisableSettings(
|
|
result._postcssResult,
|
|
'reportDescriptionlessDisables',
|
|
);
|
|
|
|
if (!settings) return;
|
|
|
|
const [enabled, options, stylelintResult] = settings;
|
|
|
|
const rangeData = stylelintResult.disabledRanges;
|
|
|
|
/** @type {Set<PostcssComment>} */
|
|
const alreadyReported = new Set();
|
|
|
|
Object.keys(rangeData).forEach((rule) => {
|
|
rangeData[rule].forEach((range) => {
|
|
if (range.description) return;
|
|
|
|
if (alreadyReported.has(range.comment)) return;
|
|
|
|
if (enabled === optionsMatches(options, 'except', rule)) {
|
|
// An 'all' rule will get copied for each individual rule. If the
|
|
// configuration is `[false, {except: ['specific-rule']}]`, we
|
|
// don't want to report the copies that match except, so we record
|
|
// the comment as already reported.
|
|
if (!enabled && rule === 'all') alreadyReported.add(range.comment);
|
|
|
|
return;
|
|
}
|
|
|
|
alreadyReported.add(range.comment);
|
|
|
|
// If the comment doesn't have a location, we can't report a useful error.
|
|
// In practice we expect all comments to have locations, though.
|
|
if (!range.comment.source || !range.comment.source.start) return;
|
|
|
|
result.warnings.push({
|
|
text: `Disable for "${rule}" is missing a description`,
|
|
rule: '--report-descriptionless-disables',
|
|
line: range.comment.source.start.line,
|
|
column: range.comment.source.start.column,
|
|
severity: options.severity,
|
|
});
|
|
});
|
|
});
|
|
});
|
|
};
|