react-native-devtools-frontend

mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-01 01:38:07 +08:00

Files

T

Tim van der Lippe 25f1108994 Reland "Cleanup path handling in collect-strings"

This reverts commit 29fe69257e.

Reason for revert:
1. Fix Windows compatibility by fixing the various
path separators to use UNIX when they need to be UNIX.
2. Ensure that whenever we change this script, we run the corresponding
PRESUBMIT. Otherwise, you can submit a CL that passes presubmit, but
starts failing on a later CL.
3. Lastly, let's output the full `git diff` so that it makes it easier
to investigate these kind of problems. Example git diff I used:
https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket.appspot.com/8843531480879659408/+/u/presubmit_py3/stdout

DISABLE_THIRD_PARTY_CHECK=Fixes in presubmit and presubmit script

Original change's description:
> Revert "Cleanup path handling in collect-strings"
>
> This reverts commit 7b72fbf5d6.
>
> Reason for revert: speculative revert based on https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_win64/b8843551589142089360/overview
>
> Original change's description:
> > Cleanup path handling in collect-strings
> >
> > While reading through this script I spotted a lot of duplication
> > of `front_end` in its path handling. Since we assume that all
> > strings are collected from `front_end/`, we can pass in that
> > path and use that, cleaning up most of the path concatenation
> > in the script.
> >
> > DISABLE_THIRD_PARTY_CHECK=Path handling fixes in collect-strings
> > R=szuend@chromium.org
> >
> > Bug: none
> > Change-Id: I0e7d004ad4d1d16f92cd88f3fed94dfe4c4108b0
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2982134
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
>
> Bug: none
> Change-Id: I6e1ac7046950f78aa7339efb21559ff60f3d50f7
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2982147
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Bug: none
Change-Id: Ia42890a67e53abdc9bacfb9e98cf06a975148bde
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2983032
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>