mirror of
https://github.com/react/react-native-devtools-frontend.git
synced 2026-10-10 05:35:05 +08:00
Also update the PRESUBMIT linter configuration to make sure it actually runs the linter when updating ESLint. Otherwise, it would not properly do the full linter check. R=jacktfranklin@chromium.org DISABLE_THIRD_PARTY_CHECK=Update ESLint Bug: 1068145 Change-Id: Ibf2de156366dc64c90ee1aced5537d2038e7a268 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2137384 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
63 lines
1.6 KiB
JavaScript
63 lines
1.6 KiB
JavaScript
/**
|
|
* @fileoverview enforce default parameters to be last
|
|
* @author Chiawen Chen
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
module.exports = {
|
|
meta: {
|
|
type: "suggestion",
|
|
|
|
docs: {
|
|
description: "enforce default parameters to be last",
|
|
category: "Best Practices",
|
|
recommended: false,
|
|
url: "https://eslint.org/docs/rules/default-param-last"
|
|
},
|
|
|
|
schema: [],
|
|
|
|
messages: {
|
|
shouldBeLast: "Default parameters should be last."
|
|
}
|
|
},
|
|
|
|
create(context) {
|
|
|
|
// eslint-disable-next-line jsdoc/require-description
|
|
/**
|
|
* @param {ASTNode} node function node
|
|
* @returns {void}
|
|
*/
|
|
function handleFunction(node) {
|
|
let hasSeenPlainParam = false;
|
|
|
|
for (let i = node.params.length - 1; i >= 0; i -= 1) {
|
|
const param = node.params[i];
|
|
|
|
if (
|
|
param.type !== "AssignmentPattern" &&
|
|
param.type !== "RestElement"
|
|
) {
|
|
hasSeenPlainParam = true;
|
|
continue;
|
|
}
|
|
|
|
if (hasSeenPlainParam && param.type === "AssignmentPattern") {
|
|
context.report({
|
|
node: param,
|
|
messageId: "shouldBeLast"
|
|
});
|
|
}
|
|
}
|
|
}
|
|
|
|
return {
|
|
FunctionDeclaration: handleFunction,
|
|
FunctionExpression: handleFunction,
|
|
ArrowFunctionExpression: handleFunction
|
|
};
|
|
}
|
|
};
|