zzos/react-native
1
0
Fork 0
mirror of https://github.com/react/react-native.git synced 2026-09-29 16:58:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix Maestro Cloud project ID reference (#57943)

Browse Source 
Summary:
- read the Maestro Cloud project ID from the repository secret in both iOS and Android jobs
- match the existing repository configuration and unblock input validation

The failing main run resolved vars.MAESTRO_CLOUD_PROJECT_ID to an empty string because MAESTRO_CLOUD_PROJECT_ID is configured as a GitHub Actions secret.

Changelog:
[Internal] [Changed] -

Pull Request resolved: https://github.com/react/react-native/pull/57943

Test Plan:
- node_modules/.bin/prettier --check .github/workflows/test-all.yml
- git diff --check

Reviewed By: huntie

Differential Revision: D115871650

Pulled By: cortinico

fbshipit-source-id: f7475fa8fcd30e334b9bf3d361f6f718bd0ca7e4
This commit is contained in:
Nicola Corti
2026-08-13 07:11:06 -07:00
committed by meta-codesync[bot]
parent b80bc19dc7
commit 9c770f5718
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/test-all.yml
+4 -4
View File
@@ -190,7 +190,7 @@ jobs:
- name: Validate Maestro Cloud inputs
env:
MAESTRO_CLOUD_API_KEY: ${{ secrets.MAESTRO_CLOUD_API_KEY }}
MAESTRO_CLOUD_PROJECT_ID: ${{ vars.MAESTRO_CLOUD_PROJECT_ID }}
MAESTRO_CLOUD_PROJECT_ID: ${{ secrets.MAESTRO_CLOUD_PROJECT_ID }}
run: |
test -n "$MAESTRO_CLOUD_API_KEY"
test -n "$MAESTRO_CLOUD_PROJECT_ID"
@@ -200,7 +200,7 @@ jobs:
uses: mobile-dev-inc/action-maestro-cloud@5759506b4ec7ee0a1ece4b7e6574bba2b282f241 # v3.0.1
with:
api-key: ${{ secrets.MAESTRO_CLOUD_API_KEY }}
project-id: ${{ vars.MAESTRO_CLOUD_PROJECT_ID }}
project-id: ${{ secrets.MAESTRO_CLOUD_PROJECT_ID }}
app-file: /tmp/RNTesterBuild/RNTester.app
workspace: packages/rn-tester/.maestro
branch: ${{ github.head_ref || github.ref_name }}
@@ -402,7 +402,7 @@ jobs:
- name: Validate Maestro Cloud inputs
env:
MAESTRO_CLOUD_API_KEY: ${{ secrets.MAESTRO_CLOUD_API_KEY }}
MAESTRO_CLOUD_PROJECT_ID: ${{ vars.MAESTRO_CLOUD_PROJECT_ID }}
MAESTRO_CLOUD_PROJECT_ID: ${{ secrets.MAESTRO_CLOUD_PROJECT_ID }}
run: |
test -n "$MAESTRO_CLOUD_API_KEY"
test -n "$MAESTRO_CLOUD_PROJECT_ID"
@@ -412,7 +412,7 @@ jobs:
uses: mobile-dev-inc/action-maestro-cloud@5759506b4ec7ee0a1ece4b7e6574bba2b282f241 # v3.0.1
with:
api-key: ${{ secrets.MAESTRO_CLOUD_API_KEY }}
project-id: ${{ vars.MAESTRO_CLOUD_PROJECT_ID }}
project-id: ${{ secrets.MAESTRO_CLOUD_PROJECT_ID }}
app-file: /tmp/rntester-android/app-x86-release.apk
workspace: packages/rn-tester/.maestro
branch: ${{ github.head_ref || github.ref_name }}