mirror of
https://github.com/react/react-native.git
synced 2026-09-28 13:23:09 +08:00
Skip set-rn-artifacts-version for PRs targeting stable branches (#55809)
Summary: When a PR targets a `-stable` branch, `github.ref_name` is the PR branch (not ending in `-stable`), so the version script was incorrectly running. Added a check for `github.base_ref` to also skip the script when the PR target branch is a stable branch. ## Changelog: [Internal] - Skip set-rn-artifacts-version for PRs targeting stable branches Pull Request resolved: https://github.com/facebook/react-native/pull/55809 Test Plan: CI should pass without running the artifacts version script on PRs targeting stable branches. Reviewed By: cortinico Differential Revision: D94678295 Pulled By: cipolleschi fbshipit-source-id: 5809ec710c191075f1bc1528ecff95f8bd745257
This commit is contained in:
committed by
meta-codesync[bot]
parent
f66d201ed6
commit
aefe0f59e2
@@ -26,7 +26,9 @@ runs:
|
||||
# already set from the 'create release' commits on the release branch.
|
||||
# For testing RC.0, though, the version has not been set yet. In that case, we are on Stable branch and
|
||||
# it is the only case when the version is still 1000.0.0
|
||||
if: ${{ !endsWith(github.ref_name, '-stable') || endsWith(github.ref_name, '-stable') && steps.read-rn-version.outputs.rn-version == '1000.0.0' }}
|
||||
# We also skip this when the PR targets a stable branch (github.base_ref ends with '-stable'),
|
||||
# since the version is already set on the stable branch.
|
||||
if: ${{ !endsWith(github.ref_name, '-stable') && !endsWith(github.base_ref || '', '-stable') || endsWith(github.ref_name, '-stable') && steps.read-rn-version.outputs.rn-version == '1000.0.0' }}
|
||||
shell: bash
|
||||
run: node ./scripts/releases/set-rn-artifacts-version.js --build-type ${{ inputs.release-type }}
|
||||
- name: Setup gradle
|
||||
|
||||
Reference in New Issue
Block a user