mirror of
https://github.com/react/react-native.git
synced 2026-09-28 13:23:09 +08:00
Dawid Małecki
dc8c442aa5
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/55910 Normalizes angle bracket spacing in scope names for template specializations. Doxygen encodes template specializations with spaces around angle brackets in compound names (e.g., `CSSDataTypeParser< CSSMatrix >`). This caused inconsistent output in API snapshots. The fix applies `normalize_angle_brackets()` to qualified paths when parsing scope names, ensuring consistent output: - `CSSDataTypeParser< CSSMatrix >` → `CSSDataTypeParser<CSSMatrix>` - `Callback< R(Args...)>` → `Callback<R(Args...)>` Added a new test case `should_normalize_template_specialization_angle_brackets` to verify the fix. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D95204780 fbshipit-source-id: d0d5fe7759a414b32630647f334b39e26da15108
73 lines
2.1 KiB
Python
73 lines
2.1 KiB
Python
# Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
#
|
|
# This source code is licensed under the MIT license found in the
|
|
# LICENSE file in the root directory of this source tree.
|
|
|
|
from __future__ import annotations
|
|
|
|
from .text_resolution import normalize_angle_brackets
|
|
|
|
|
|
def parse_qualified_path(path: str) -> list[str]:
|
|
"""
|
|
Parse a qualified path into a list of names.
|
|
|
|
Handles template syntax correctly by not splitting on "::" inside
|
|
angle brackets. For example:
|
|
- "std::vector<std::string>::test" -> ["std", "vector<std::string>", "test"]
|
|
- "ns::Foo<A, B>::Bar" -> ["ns", "Foo<A, B>", "Bar"]
|
|
|
|
Also handles edge cases:
|
|
- Comparison operators inside parentheses: "std::enable_if<(N > 0)>::type"
|
|
- Arrow operators: "decltype(ptr->member)::type"
|
|
- Bitshift operators: "std::integral_constant<int, (1 >> 2)>::value"
|
|
|
|
Normalizes angle bracket spacing (e.g., "Foo< Bar >" -> "Foo<Bar>").
|
|
"""
|
|
# Normalize angle bracket spacing before parsing
|
|
path = normalize_angle_brackets(path)
|
|
|
|
result = []
|
|
current = ""
|
|
angle_depth = 0
|
|
paren_depth = 0
|
|
i = 0
|
|
|
|
while i < len(path):
|
|
char = path[i]
|
|
|
|
if char == "(":
|
|
paren_depth += 1
|
|
current += char
|
|
i += 1
|
|
elif char == ")":
|
|
paren_depth -= 1
|
|
current += char
|
|
i += 1
|
|
elif char == "<" and paren_depth == 0:
|
|
angle_depth += 1
|
|
current += char
|
|
i += 1
|
|
elif char == ">" and paren_depth == 0:
|
|
# Check for arrow operator "->" which should not affect angle_depth
|
|
if i > 0 and path[i - 1] == "-":
|
|
current += char
|
|
i += 1
|
|
else:
|
|
angle_depth -= 1
|
|
current += char
|
|
i += 1
|
|
elif path[i : i + 2] == "::" and angle_depth == 0 and paren_depth == 0:
|
|
if current:
|
|
result.append(current)
|
|
current = ""
|
|
i += 2
|
|
else:
|
|
current += char
|
|
i += 1
|
|
|
|
if current:
|
|
result.append(current)
|
|
|
|
return result
|