react

zzos/react

Fork 0

mirror of https://github.com/react/react.git synced 2026-09-28 21:25:11 +08:00

Files

T

History

0209ef8a77 [DevTools] Fix reconciliation of content with fallback Fiber (#37475 )

## Summary

Alternative to #37280 that keeps the child-set assertion and instead
fixes the root cause.

The assertion "The children should not have changed if we pass in the
same set." fired while DevTools reconciled the hidden content tree of a
Suspense boundary that had just switched to its fallback.

`updateSuspenseChildrenRecursively` reconciles the content and the
fallback in two passes, but the previous-set lockstep pointer of the
content pass is not bounded. When a boundary is suspended on both sides
of a commit, the pointer advances from the previous content Offscreen
onto the previous fallback fragment, and the leftover-children check
reports `ShouldResetChildren` even though the fallback is reconciled in
the second pass by design.

For a boundary that is filtered from the tree, that flag propagates to
the parent child list, freezes its lockstep pointer, forces the
following sibling to be paired by alternate, and the instance scan
(which only matches the paired previous fiber) no longer finds the
existing instance, since instances track the current fiber. The subtree
below is then walked without its instance, which cascades into spurious
unmount and remount work and surfaces at the assertion in the filtered
same-child-set branch.

We're also avoiding creation of new backend instances in those
scenarios.

This change bounds the previous set of the content pass by the previous
fallback fragment via a new `prevLastChild` parameter, so the flag
disappears.

Closes #37280

## How did you test this change?

- cherry-picked test from #37280

---------

Co-authored-by: Ruslan Lesiutin <hoxy@meta.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Claude Code (kimi-k3[1m]) <noreply@anthropic.com>

2026-09-01 20:45:00 +02:00

src

[DevTools] Fix reconciliation of content with fallback Fiber (#37475 )

2026-09-01 20:45:00 +02:00

babel.config.js

Update Flow to 0.248 (#34248 )

2025-08-21 11:15:34 -04:00

buildUtils.js

feat[devtools]: add package for fusebox integration (#28553 )

2024-04-12 15:29:35 +01:00

package.json

[DevTools] Show the Suspense boundary name in the rect if there's no overlap (#34918 )