Updated the logic in `updateNotesFor` to check if a catalog is needed when no usable notes are found. This prevents unnecessary catalog queries for GitHub root installs lacking probe data. Added a test to ensure the catalog is not consulted in such cases.
Node 22's global fetch reads the legacy undici dispatcher symbol. The
host's first undici 8 import (web_fetch) writes a Dispatcher1Wrapper
there, and gzip catalog bodies then fail JSON.parse for the rest of
the process. A proxied request already passed its own dispatcher; a
direct one now does the same, with a plain Agent.
The Node 25 measurement stays beside it: there, the package's
setGlobalDispatcher does not steer global fetch at all. The two name
different Nodes and different symbols, and both are why every market
request carries a dispatcher this module created.
The Node 25 proxy measurement and the Node 22 symbol clash were written
as one argument, so a later edit could drop the direct-path dispatcher
by trusting only the first. They name different Nodes and different
symbols, and both are why every market request carries its own.
Node 22's global fetch reads the legacy undici dispatcher. The host's
first undici 8 import (web_fetch) replaces it, and gzip catalog bodies
then fail JSON.parse for the rest of the process. A proxied request
already passed a dispatcher; a direct one now does the same.
The scanner's detail is itself a sentence — "overrides bundle …" or
"disables bundle …" — and the translation was pasting that detail
through. A reader then had to parse the English verb to learn whether
the install would replace a part of DSH or switch one off. Those two
shapes are the only details the scanner emits.
A detail that is neither of those stays on the generic sentence, so a
future shape is not guessed into an override or a disable.
This test verifies that when an unrecognized core-bundle detail is present, it remains on the generic sentence without being incorrectly classified as an override or disable. The test ensures the expected behavior of the MarketSection component in this scenario.
The scanner's detail is itself a sentence — "overrides bundle …" or
"disables bundle …" — and the translation was pasting that detail
through. A reader then had to parse the English verb to learn whether
the install would replace a part of DSH or switch one off. Those two
shapes are the only details the scanner emits.
Follow-up to #665 from merge review.
The allowlist required `.git` on a clone-URL key, so a self-hosted remote
installed as `git+https://host/owner/repo` had its key derived correctly and
then dropped on the way out — the same silent hole #665 closed, one spelling
over.
The suffix is now optional rather than appended. pnpm keys a remote exactly
as it was spelled: measured on 12.4.1 against a remote without `.git`, the
key as spelled authorizes the build and the key with `.git` appended does
not, so "normalizing" would have written an entry pnpm never reads. The same
spelling pinned with `#<sha>` is what 11.8.0 matches.
Also from the review: `codeloadAllowBuildsKey`'s doc had ended up above
`pinnedGitAllowBuildsKey`, and a couple of comments still said "github".
* fix(client): resolve ui-primitives icons across the 0.1.7 rename (#671)
Host 0.1.7-alpha.1 dropped size-suffixed icon exports for Regular/Medium
with no alias, so MarketSection rendered undefined and threw React #130.
Pick the new name when present, fall back to the old one, and skip
registration when neither spelling exists.
* fix(client): harden icon resolve for exotic components and real exports (#671)
Accept memo/forwardRef-shaped primitives exports, not only plain functions,
and pin the alias table against the measured 0.1.6 / 0.1.7 icon export lists.
* fix(client): prefer Regular icons and skip missing glyphs (#671)
Align with the size-vs-weight split on 0.1.7: always resolve …Regular first,
keep call-site `size` props, and render nothing (with a warning) when neither
spelling exists so a rename cannot blank the market. Also guard host-table
lookups that throw on unknown keys.
Co-authored-by: GnaneshKunal <20211167+GnaneshKunal@users.noreply.github.com>
---------
Co-authored-by: GnaneshKunal <20211167+GnaneshKunal@users.noreply.github.com>
Ungrouped rows reused the card shell, so the name sat above an empty band and Assign filled the row. The group header put rename and delete next to add. Both are one line now: the header keeps the switch, Choose/Change theme, and Add members, with rename and delete in the overflow menu. An ungrouped row is the name, a short status, a truncated note, and Assign.
A group holds one theme, so choosing one is its own dialog, not another checkbox in Add members. The theme stays the first row, marked "· Theme", and choosing it does not enable it. Adding plugins does not enable them either. Search filters groups by name, member, note, and description. Leaving the new-group field, or pressing Esc, restores the button.
Enhanced the group creation process by consolidating the cancellation logic into a reusable callback function. Updated the UI to ensure that the group creation input field is cleared and the state is reset upon cancellation, either through button clicks or focus loss. Improved keyboard accessibility by allowing cancellation with the Escape key. This refactor aims to simplify the code and improve user experience during group management.
Updated the group management interface to improve user experience by introducing modals for adding members and renaming groups. Enhanced the layout for better visibility and interaction, ensuring that actions like adding members and changing themes are more intuitive. Added new localization strings for improved internationalization support. Adjusted CSS for better alignment and spacing in group-related components.
Ungrouped rows reused the column .irow card shell, so flex-grow left a tall
empty band above Assign. Use a compact horizontal row, restore the missing
.sect label style, and demote delete behind add actions.
* fix(client): load host requirements on the favorites tab
Favorites reuse pluginCard badges but only Discover was fetching
discovery-compatibility, so bookmark-only packages stayed on loading.
* chore(client): rebuild bundle for favorites host-requirement fix
Compatible host-requirement badges used the same chrome as category tags;
keep red only for a confirmed mismatch. Status / filtering / data-status unchanged.
Compatible cards were wearing a green success chip next to grey category tags, so every discovery card looked decorated. Matching the category chrome leaves colour for a confirmed mismatch only.
The inherited PATH is never empty, so leaving it in place would keep the bundled Node off the path. Proxy and GIT_TERMINAL_PROMPT still keep a value the caller already set.
- Official Desktop GUI installs failed with `env: node: No such file or
directory`: the shell's PATH has no node, so the pnpm on PATH could not
run (#653, by @Yur0918 in #654). The market now prefers the host's own
package manager and env when the launcher publishes them, and `env: node:`
is no longer diagnosed as a corepack network problem.
- A market restart that never comes back no longer takes the UI with it
(#650, by @Karl-441). The helper waits until the replacement is actually
listening, then offers "adjust plugins" on the same origin — implicated
plugins unticked — writes the patch, and starts again. Only market-triggered
restarts; loopback + same-origin POST; only names that were in the list
before the restart.
- Updating a GitLab or Bitbucket install no longer silently swaps in the
npm package of the same name (#637, by @po-et in #656). `gitlab:` /
`bitbucket:` are git sources; identity is host + owner/repo, including
archive tarballs in the lockfile.
- `runtime` / `restart.managedBy` follow the desktop shell, not "a profile
directory exists" (#655, by @po-et), so an ordinary `dsh web` is not
reported as desktop.
- Desktop staging `ERR_PNPM_UNEXPECTED_STORE` stops telling people to relink
the profile (#652, by @elkaix); the Chinese UI gets the matching half of
that pair (#658).
Co-authored-by: Cursor <cursoragent@cursor.com>
Follow-up to #652: the Desktop staging unexpected-store branch is a
中文 / English pair again, so a Chinese UI no longer shows the whole
English sentence. Same remediations; still no --store-dir.
Refactor the error message for unexpected-store when the desktop client's install staging directory is claimed by a pnpm workspace. The message now includes a Chinese translation, providing clearer guidance on how to resolve the issue. Additionally, update tests to verify the presence of the new translations in the error messages.
The through-line is the text the market puts in front of people:
long release notes that used to overflow, and bilingual copy that
used to stay in one language.
- Update-notes dialogs scroll, strip pasted HTML images, and render
links / fences / quotes (#547).
- CJK / bilingual strings localize for the active UI language (#534).
- Discover cards can show the catalog's npm latest version on the
byline when the catalog provides it (#515 / #348).
Reading release prose in the default narrow Modal felt cramped; size
the notes dialog to 640px and use the existing gotIt copy (关闭 /
Dismiss) instead of Cancel.
Release bodies still looked raw after the scroll fix: [text](url),
``` fences, and > quotes were plain text. Teach the tiny renderer those
shapes (https links only) and give the scroll body bottom padding so
content does not sit under the Cancel button.
Cap the notes dialog body so long release text scrolls inside the
modal, drop literal HTML (especially GitHub-pasted <img>) before the
tiny markdown renderer, and allow allowlisted https markdown images.
- Replaced the Chinese rollback message with its English equivalent in the test case to ensure accurate verification of the displayed message when the server cannot confirm the exact source.
- Updated assertions to check for the presence of the English message and the absence of the original Chinese message, improving test clarity and accuracy.
- Introduced functions to count CJK characters, pick the appropriate language from bilingual strings, and localize lists of bilingual reasons.
- Updated various components to utilize these new localization functions, ensuring that error messages and status lines are displayed in the correct language based on user preference.
- Enhanced the `statusLine` and `setInstallError` functions to support bilingual output, improving user experience for Chinese and English speakers.
- Added tests for the new localization functions to ensure correct behavior across different scenarios.
* test: accept git+https lock shape in #385 compat probe
pnpm now resolves github: shortcuts as git+https / type: git instead of
codeload tarballs with gitHosted. Keep both shapes; only poison the
proxy orphan path when the seed lock is still codeload.
* test: enhance compatibility for github shortcuts in lock shapes
Updated the handling of github:owner/repo#sha shortcuts to support both
git+https and git+ssh formats, reflecting current pnpm behavior.
Introduced a new function to create orphaned proxy lockfiles for legacy
compatibility, ensuring proper installation and mutation handling in
tests.
Introduced a new state `stuckExpanded` to manage the expansion of categories when the sticky header is active. This change ensures that the expansion state is consistent with user interactions, allowing for a smoother experience when toggling category visibility. Updated related logic to synchronize the `catsOpen` state with the new `catsExpanded` derived from `stuckExpanded`. Adjusted scroll event handling to prevent unnecessary state updates. Improved test coverage for category row expansion behavior under sticky conditions.
Give the back-to-top control an opaque disc under the outline Button,
wrap long host/category tags inside .footTags so favorite/comments stay
on the right, and close the per-page Menu after a pick.
* fix: do not treat private git installs as npm on update (#525)
repoOfTarget only recognized github:/codeload, so a Gitea git+https
spec fell through to name@latest. Detect git-hosted remotes, compare
HEAD via smart HTTP, and re-add the git URL instead of the registry.
Co-authored-by: Cursor <cursoragent@cursor.com>
* feat: enhance git URL handling for private hosts and Gitea support
- Introduced `looksLikeHttpsGitRemote` to identify valid git URLs without the `.git` suffix, accommodating Gitea and GitLab formats.
- Updated `gitUpdateTarget` to correctly rewrite GitHub URLs to `github:` format during updates, ensuring proper handling of private git installations.
- Enhanced `gitUploadPackUrl` to strip user info from URLs for security during smart-HTTP probes.
- Added tests to verify the handling of Gitea URLs and ensure they are treated as git remotes, not npm packages.
This addresses issues with private git installations falling back to npm name parsing, improving the update flow for self-hosted git services (#525).
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
Pin the update add target to the registry version already resolved for the
downgrade guard so Desktop's install boundary does not fetch latest again.
Keep resolvedNpmVersion only as a fallback when the add still carries a
floating dist-tag, and never let it lower an exact pin the route sent.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix: enhance local development restore functionality in Market section
- Updated the MarketSection component to improve the handling of local development restores, ensuring the restore button is correctly displayed and functional.
- Adjusted CSS styles for better layout and readability of installed rows, including the addition of a new button for restoring local development plugins.
- Modified tests to verify the correct behavior of the restore functionality, ensuring that the user experience is seamless and intuitive.
* fix: enhance restore functionality in Market section with modal confirmation
- Added a new confirmation modal for restoring local development plugins, improving user experience by requiring explicit confirmation before proceeding.
- Updated the restore button text to "Confirm restore" for clarity, aligning with the new modal functionality.
- Adjusted tests to verify the correct behavior of the restore process, ensuring that the modal appears as expected and that the restore action is handled correctly.
- Made minor CSS adjustments to improve the layout of action buttons in the Market section.
* fix: add restore failure handling and improve user feedback in Market section
- Introduced a new title for the restore failure modal to enhance clarity for users when a plugin cannot be restored due to absence in the catalog.
- Updated the restore button's behavior to ensure it is only enabled when appropriate, preventing unnecessary actions.
- Adjusted the modal footer button text for better user understanding.
- Enhanced tests to validate the new modal behavior and ensure proper user feedback during restore operations.
* feat: implement catalog matching for local file installs
- Introduced a new module for catalog matching of locally linked and file-based installs, enhancing the restore functionality for plugins.
- Added functions to validate subpaths and extract catalog match keys from GitHub URLs, ensuring accurate identification of plugins.
- Updated the Market section to utilize the new catalog matching logic, improving the handling of local development restores.
- Enhanced tests to cover new functionality, ensuring correct behavior when restoring plugins with conflicting identities.
* feat: enhance restore functionality with detailed feedback and new catalog matching logic
- Added a new message for users when a local plugin cannot be safely restored due to a mismatch with the catalog.
- Implemented functions to resolve catalog restoration issues, distinguishing between missing catalog entries and repository mismatches.
- Updated the Market section to utilize the new restoration logic, improving user experience during local development restores.
- Enhanced tests to cover new functionality, ensuring accurate behavior when restoring plugins with conflicting identities.
* fix: improve local plugin matching logic in market data
- Enhanced the `matchInstalledName` function to better handle local file and link installations, ensuring accurate identification of installed plugins.
- Updated the logic to prevent false positives when matching plugins with similar names but different repository identities.
- Added new tests to validate the behavior of the updated matching logic, particularly in scenarios with conflicting identities and local development setups.
- Improved existing tests to ensure comprehensive coverage of the new functionality.
---------
Co-authored-by: fkysly <fkysly@gmail.com>
* feat: implement favorites functionality for plugins
This update introduces a favorites feature allowing users to bookmark plugin URLs for later access. The implementation includes:
- New UI elements for adding/removing favorites in the client.
- Backend support for managing favorites, including API endpoints for adding and removing favorites.
- Updates to the market state to persist favorites across sessions.
- Localization updates for new favorite-related strings in both English and Chinese.
- Tests to ensure the functionality works as expected, including edge cases for invalid URLs.
This feature enhances user experience by providing a way to easily access preferred plugins.
* feat: enhance favorites section with plugin and theme grouping
This update introduces a new grouping feature for favorites, allowing users to view their saved items categorized into plugins and themes. Key changes include:
- Updated UI to display separate sections for plugins and themes within the favorites tab.
- Localization updates for new section headers in both English and Chinese.
- Adjustments to pagination logic to handle separate counts for plugins and themes.
- Added tests to verify the correct grouping and display of favorites.
This enhancement improves user experience by providing clearer organization of favorite items.
* feat: implement stale favorites management and limit
This update enhances the favorites functionality by introducing a mechanism to manage stale favorites, allowing users to clear bookmarks that are no longer in the catalog. Key changes include:
- New UI elements for displaying and clearing stale favorites in both English and Chinese.
- Backend support for identifying and removing stale favorites, with a limit set to 500 favorites.
- Localization updates for new strings related to stale favorites.
- Tests to ensure the functionality works as expected, including edge cases for stale entries.
This improvement enhances user experience by keeping the favorites list relevant and manageable.
* feat: implement queuing for favorite writes during ongoing installations
This update introduces a mechanism to queue favorite operations while an installation is in progress, preventing conflicts and ensuring a smoother user experience. Key changes include:
- New function `withMutationQueued` to handle queued favorite writes.
- Updated error handling to provide user feedback when favorites are busy.
- Localization updates for new messages related to queued favorites.
- Tests to verify the queuing behavior during concurrent operations.
This enhancement improves the reliability of the favorites feature by managing concurrent modifications effectively.
---------
Co-authored-by: fkysly <fkysly@gmail.com>
* fix: ensure notes display correctly for plugins without catalog descriptions (#458)
- Updated the MarketSection component to conditionally render notes only when they are not empty, preventing unnecessary null returns.
- Adjusted CSS styles for note rows to improve layout and spacing, ensuring a consistent appearance.
- Added tests to verify that the "add-note" button is visible even when a plugin lacks a catalog description, enhancing user experience.
* fix: improve layout and spacing for note rows in Market module
- Added CSS adjustments to ensure proper spacing between note rows, enhancing readability and layout consistency.
- Updated styles to prevent visual overlap between note rows and description lines, addressing layout issues reported in #458.
* feat: add debugger detection to prevent self-restart during debugging sessions
This update introduces a mechanism to detect if the host process is under a debugger, specifically using the Node.js inspector. When a debugger is detected, self-restart functionality is disabled to prevent potential issues. The UI has been updated to reflect this state, providing appropriate messages to users. Additionally, tests have been added to ensure the new behavior is correctly enforced.
* feat: enhance debugger detection with new inspect-wait flag support
This update expands the debugger detection mechanism to include the `--inspect-wait` flag, allowing for better handling of debugging sessions. The UI has been updated to reflect the debugger state, and tests have been added to ensure the new flag is correctly recognized. Additionally, the MarketSection component now updates the debugger latch based on the fetched status, improving user feedback during debugging operations.
* refactor: update GitHub mark description for catalog card titles
Enhanced the documentation for the GitHub mark component beside catalog card titles to clarify its unconditional rendering based on URL validation. This change ensures users understand the component's behavior without relying on hover actions.
* refactor: update CSS styles and improve client.js.map for better performance
This commit refines the CSS styles in client.js to enhance the layout and responsiveness of the market section. Additionally, the client.js.map file has been updated to reflect the latest changes in the source files, ensuring accurate mapping for debugging and development purposes.
---------
Co-authored-by: fkysly <fkysly@gmail.com>
This update introduces a visual GitHub mark beside the titles of catalog cards, enhancing user experience by clearly indicating the destination of the links without requiring hover actions. The new component replaces the previous icon and maintains the layout integrity of the card design. Additionally, related tests have been updated to reflect this change.
Co-authored-by: fkysly <fkysly@gmail.com>
Liu Wenjie