mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-09-29 17:23:59 +08:00
Teknium
a5bd246865
* refactor(plugins): remove the Sep 2026 decomposition compat layer on schedule The PLUGIN-COMPAT layer (2776813df3+d63e380324+0a5164cebe) kept pre-#102117 import paths alive for external plugins until 2026-09-14. That window closed two weeks ago; since then the loader has already been skipping plugins that use the old paths. This removes the layer itself: - 328 appended `PLUGIN-COMPAT` blocks (lazy `__getattr__` pointer tables, re-exported third-party names, restored dead definitions) and the three re-export stub modules (gateway/startup_watchdog, hermes_cli/observability/relay_runtime, tools/environments/modal_utils) - COMPAT_MANIFEST.md, compat_manifest.json, scripts/check_compat_pointers.py and its lint step - the reporting surfaces: CLI banner notice, `hermes plugins compat`, the `hermes doctor` section, the post-update notice, the Desktop one-time dialog, the loader's pre-import skip and the `plugins.allow_deprecated_imports` escape hatch An external plugin that still imports an old path now fails to load with its ImportError as the reason in `hermes plugins list`, the same path as any broken plugin. hermes_cli/plugin_compat.py stays as three inert stubs (compat_report, removal_in_effect, summary_lines): an already-running pre-removal `hermes update` lazy-imports them after the checkout swap (tests/compat/old_updater_surface.json). In-tree fallout, both already dead: hermes_cli/setup.py::_check_espeak_ng (no callers; its `shutil` came from a compat block) and gateway/config.py::SessionResetPolicy ("retained solely for the scheduled plugin-compat window"). Two test_run_agent patches targeted the removed `run_agent.handle_function_call` pointer; they now patch `model_tools.handle_function_call`, the seam production reads, like every sibling test in that file. * chore: retrigger CI (zero-job startup_failure phantom) * test: drop resolution allowlist rows for the two deleted which() sites hermes_cli/setup.py::_check_espeak_ng (dead) and tools/skillevaluator_scan.py::scanner_available (a restored definition inside a PLUGIN-COMPAT block) no longer exist; the stale-row gate requires their allowlist entries go with them.
90 lines
3.2 KiB
Python
90 lines
3.2 KiB
Python
#!/usr/bin/env python3
|
|
"""Open a URL, dev server, or file in the Hermes desktop GUI's preview pane.
|
|
|
|
Registration lives in the `desktop_preview` tool (``tools.preview_tool``); this module keeps
|
|
the normalizer + open action. Emits ``preview.open`` via ``desktop_ui``: the renderer opens
|
|
the pane for the window that asked and never steals focus for a background session.
|
|
"""
|
|
|
|
import os
|
|
import re
|
|
from pathlib import Path
|
|
from urllib.parse import unquote, urlparse
|
|
|
|
from tools import desktop_ui
|
|
from tools.registry import tool_error
|
|
|
|
|
|
def _normalize_target(raw: str) -> str:
|
|
"""Coax a bare host/domain into a fetchable URL; leave paths + schemes alone.
|
|
|
|
``www.cnn.com`` -> ``https://www.cnn.com``; ``localhost:3000`` -> ``http://localhost:3000``.
|
|
File paths and explicit schemes pass through for the renderer's preview normalizer.
|
|
"""
|
|
v = raw.strip().strip("`").strip()
|
|
if not v or "://" in v or v.startswith(("/", "./", "../", "~", "file:")):
|
|
return v
|
|
if re.match(r"^(localhost|127\.0\.0\.1|0\.0\.0\.0|\[::1\])(:\d+)?(/|$)", v, re.I):
|
|
return "http://" + v
|
|
if re.match(r"^[\w.-]+\.[a-z]{2,}(:\d+)?(/.*)?$", v, re.I):
|
|
return "https://" + v
|
|
return v
|
|
|
|
|
|
def _local_fs_path(target: str) -> Path | None:
|
|
"""Return a filesystem path for local targets; None for http(s) URLs."""
|
|
raw = (target or "").strip()
|
|
if not raw:
|
|
return None
|
|
if "://" in raw:
|
|
parsed = urlparse(raw)
|
|
if parsed.scheme.lower() != "file":
|
|
return None
|
|
path = unquote(parsed.path or "")
|
|
if parsed.netloc and parsed.netloc not in {"", "localhost"}:
|
|
path = f"//{parsed.netloc}{path}"
|
|
elif (
|
|
os.name == "nt"
|
|
and len(path) >= 3
|
|
and path[0] == "/"
|
|
and path[2] == ":"
|
|
):
|
|
path = path[1:]
|
|
return Path(path) if path else None
|
|
return Path(raw).expanduser()
|
|
|
|
|
|
def _is_existing_directory(target: str) -> bool:
|
|
path = _local_fs_path(target)
|
|
if path is None:
|
|
return False
|
|
try:
|
|
return path.is_dir()
|
|
except OSError:
|
|
# Stat failed (permissions, broken reparse, etc.). Do not treat that
|
|
# as "this is a directory" — reject only when we positively observe
|
|
# an existing directory. The renderer still sees the original target.
|
|
return False
|
|
|
|
|
|
def open_preview_tool(url: str, label: str = "") -> str:
|
|
"""Ask the desktop GUI to show ``url`` in the preview pane beside the chat."""
|
|
target = _normalize_target(url or "")
|
|
if not target:
|
|
return tool_error(
|
|
"url is required — a web URL (https://…), a localhost dev server, or a "
|
|
"file path to show in the preview pane.")
|
|
if _is_existing_directory(target):
|
|
return tool_error(
|
|
"directories are not previewable — pass a file path or a URL. "
|
|
f"{target} is a directory."
|
|
)
|
|
|
|
label = (label or "").strip()
|
|
return desktop_ui.emit_or_error(
|
|
"preview.open",
|
|
{"url": target, "label": label},
|
|
"Failed to open the preview pane: ",
|
|
"The preview pane is only available in the Hermes desktop app.",
|
|
{"success": True, "url": target, "label": label})
|