zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-03 02:21:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Stop running unit tests on presubmit

Browse Source 
These unit tests run on a separate bot, dedicated to running tests.
Having these run in the presubmit as well lengthens CL upload time and
could cause more troubles in the presubmit bots.

Change-Id: I62aec994c2346e0b4e558bd88e9c64b77875f007
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2039570
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
This commit is contained in:
Tim van der Lippe
2020-02-06 14:31:07 +00:00
committed by Commit Bot
parent 33e8f6fbe8
commit 11adee4a0c
1 changed files with 0 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
PRESUBMIT.py
-13
View File
@@ -99,18 +99,6 @@ def _CheckLicenses(input_api, output_api):
return results
def _CheckUnitTests(input_api, output_api):
results = [output_api.PresubmitNotifyResult('Running Unit Tests:')]
unittest_root = input_api.os_path.join(input_api.PresubmitLocalPath(), 'test')
affected_unittest_files = _getAffectedFiles(input_api, [unittest_root], ['D'], ['.ts'])
if len(affected_unittest_files) == 0:
return results
script_path = input_api.os_path.join(input_api.PresubmitLocalPath(), 'scripts', 'test', 'check_for_unittest_onlys.js')
results.extend(_checkWithNodeScript(input_api, output_api, script_path, affected_unittest_files))
return results
def _CheckFormat(input_api, output_api):
results = [output_api.PresubmitNotifyResult('Running Format Checks:')]
def popen(args):
@@ -301,7 +289,6 @@ def _CommonChecks(input_api, output_api):
results.extend(_CheckOptimizeSVGHashes(input_api, output_api))
results.extend(_CheckCSSViolations(input_api, output_api))
results.extend(_CheckChangesAreExclusiveToDirectory(input_api, output_api))
results.extend(_CheckUnitTests(input_api, output_api))
results.extend(_CheckNoUncheckedFiles(input_api, output_api))
results.extend(_CheckForTooLargeFiles(input_api, output_api))
return results