Update CDP and add string to reflect stack scope in scope view

DISABLE_THIRD_PARTY_CHECK=Change to reflect CDP update

Bug: chromium:1043034
Bug: v8:10347
Change-Id: I777072a1263f93b228263d065c2e0e95707774dd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2128128
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
This commit is contained in:
Kim-Anh Tran
2020-03-31 12:26:33 +00:00
committed by Commit Bot
parent d7f02588fc
commit 2dbeb5da18
6 changed files with 42 additions and 9 deletions
@@ -2212,7 +2212,8 @@ export function registerCommands(inspectorBackend) {
Block: 'block',
Script: 'script',
Eval: 'eval',
Module: 'module'
Module: 'module',
WasmExpressionStack: 'wasm-expression-stack'
});
inspectorBackend.registerEnum(
'Debugger.BreakLocationType', {DebuggerStatement: 'debuggerStatement', Call: 'call', Return: 'return'});
@@ -2438,7 +2439,8 @@ export function registerCommands(inspectorBackend) {
Number: 'number',
Boolean: 'boolean',
Symbol: 'symbol',
Bigint: 'bigint'
Bigint: 'bigint',
Wasm: 'wasm'
});
inspectorBackend.registerEnum('Runtime.RemoteObjectSubtype', {
Array: 'array',
@@ -2457,7 +2459,12 @@ export function registerCommands(inspectorBackend) {
Promise: 'promise',
Typedarray: 'typedarray',
Arraybuffer: 'arraybuffer',
Dataview: 'dataview'
Dataview: 'dataview',
I32: 'i32',
I64: 'i64',
F32: 'f32',
F64: 'f64',
V128: 'v128'
});
inspectorBackend.registerEnum('Runtime.ObjectPreviewType', {
Object: 'object',
+8 -1
View File
@@ -11403,6 +11403,7 @@ declare namespace Protocol {
Script = 'script',
Eval = 'eval',
Module = 'module',
WasmExpressionStack = 'wasm-expression-stack',
}
/**
@@ -12628,6 +12629,7 @@ declare namespace Protocol {
Boolean = 'boolean',
Symbol = 'symbol',
Bigint = 'bigint',
Wasm = 'wasm',
}
export enum RemoteObjectSubtype {
@@ -12648,6 +12650,11 @@ declare namespace Protocol {
Typedarray = 'typedarray',
Arraybuffer = 'arraybuffer',
Dataview = 'dataview',
I32 = 'i32',
I64 = 'i64',
F32 = 'f32',
F64 = 'f64',
V128 = 'v128',
}
/**
@@ -12659,7 +12666,7 @@ declare namespace Protocol {
*/
type: RemoteObjectType;
/**
* Object subtype hint. Specified for `object` type values only.
* Object subtype hint. Specified for `object` or `wasm` type values only.
*/
subtype?: RemoteObjectSubtype;
/**
+2
View File
@@ -1485,6 +1485,8 @@ export class Scope {
return Common.UIString.UIString('Global');
case Protocol.Debugger.ScopeType.Module:
return Common.UIString.UIString('Module');
case Protocol.Debugger.ScopeType.WasmExpressionStack:
return Common.UIString.UIString('Stack');
}
return '';
}
+3
View File
@@ -60,6 +60,9 @@
<message name="IDS_DEVTOOLS_212af9ab36fa426a9e52bc1ebfd8665b" desc="Text in DOMDebugger Model">
Drag / drop
</message>
<message name="IDS_DEVTOOLS_2187e1021a911b3807cc1bea2eb1a9ca" desc="Text for a stack, the programming concept">
Stack
</message>
<message name="IDS_DEVTOOLS_22af645d1859cb5ca6da0c484f1f37ea" desc="Service worker version status displayed in the Threads view of the Debugging side pane in the Sources panel">
new
</message>
@@ -16828,7 +16828,8 @@
"block",
"script",
"eval",
"module"
"module",
"wasm-expression-stack"
]
},
{
@@ -18664,12 +18665,13 @@
"number",
"boolean",
"symbol",
"bigint"
"bigint",
"wasm"
]
},
{
"name": "subtype",
"description": "Object subtype hint. Specified for `object` type values only.",
"description": "Object subtype hint. Specified for `object` or `wasm` type values only.",
"optional": true,
"type": "string",
"enum": [
@@ -18689,7 +18691,12 @@
"promise",
"typedarray",
"arraybuffer",
"dataview"
"dataview",
"i32",
"i64",
"f32",
"f64",
"v128"
]
},
{
+8 -1
View File
@@ -119,6 +119,7 @@ domain Debugger
script
eval
module
wasm-expression-stack
# Object representing the scope. For `global` and `with` scopes it represents the actual
# object; for the rest of the scopes, it is artificial transient object enumerating scope
# variables as its properties.
@@ -954,7 +955,8 @@ domain Runtime
boolean
symbol
bigint
# Object subtype hint. Specified for `object` type values only.
wasm
# Object subtype hint. Specified for `object` or `wasm` type values only.
optional enum subtype
array
null
@@ -973,6 +975,11 @@ domain Runtime
typedarray
arraybuffer
dataview
i32
i64
f32
f64
v128
# Object class (constructor) name. Specified for `object` type values only.
optional string className
# Remote object value in case of primitive values or JSON values (if it was requested).