zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-12 17:45:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary _CheckCSSViolations check

Browse Source 
These selectors are already removed from Blink and therefore no longer
work.

R=aerotwist@chromium.org

Change-Id: I3131d3cf5cb27eafa13e07ba65b87fc77e8dbae1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2087767
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
This commit is contained in:
Tim van der Lippe
2020-03-06 16:13:35 +00:00
committed by Commit Bot
parent 9d8c9bf34d
commit 5afd571cd4
1 changed files with 0 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
PRESUBMIT.py
-13
View File
@@ -186,18 +186,6 @@ def _CheckOptimizeSVGHashes(input_api, output_api):
return results
def _CheckCSSViolations(input_api, output_api):
results = [output_api.PresubmitNotifyResult('Running CSS Violation Check:')]
for f in input_api.AffectedFiles(include_deletes=False):
if not f.LocalPath().endswith('.css'):
continue
for line_number, line in f.ChangedContents():
if '/deep/' in line:
results.append(output_api.PresubmitError(('%s:%d uses /deep/ selector') % (f.LocalPath(), line_number)))
if '::shadow' in line:
results.append(output_api.PresubmitError(('%s:%d uses ::shadow selector') % (f.LocalPath(), line_number)))
return results
def _CheckGeneratedFiles(input_api, output_api):
v8_directory_path = input_api.os_path.join(input_api.PresubmitLocalPath(), 'v8')
@@ -288,7 +276,6 @@ def _CommonChecks(input_api, output_api):
results.extend(_CheckDevtoolsStyle(input_api, output_api))
results.extend(_CheckFormat(input_api, output_api))
results.extend(_CheckOptimizeSVGHashes(input_api, output_api))
results.extend(_CheckCSSViolations(input_api, output_api))
results.extend(_CheckChangesAreExclusiveToDirectory(input_api, output_api))
results.extend(_CheckNoUncheckedFiles(input_api, output_api))
results.extend(_CheckForTooLargeFiles(input_api, output_api))