zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-07 04:26:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Lighthouse] Remove DOM check when adding view trace button

Browse Source 
Lighthouse's `addButton` handles this for us–and besides,
the DOM has changed and this check is no longer valid.

Bug: 1262253
Change-Id: I63a1442a07fb139a6a7d760f76d57e546b36e0f7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3237595
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
This commit is contained in:
Paul Irish
2021-10-21 20:32:19 +00:00
committed by Devtools-frontend LUCI CQ
parent 1139798e6b
commit 6ee740ea29
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
front_end/panels/lighthouse/LighthouseReportRenderer.ts
-5
View File
@@ -51,11 +51,6 @@ export class LighthouseReportRenderer extends LighthouseReport.ReportRenderer {
if (!container) {
return;
}
const disclaimerEl = container.querySelector('.lh-metrics__disclaimer');
// If it was a PWA-only run, we'd have a trace but no perf category to add the button to
if (!disclaimerEl) {
return;
}
const defaultPassTrace = artifacts.traces.defaultPass;
const text = simulated ? i18nString(UIStrings.viewOriginalTrace) : i18nString(UIStrings.viewTrace);