zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-09-30 01:07:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use TypeScript Interface instead of class

Browse Source 
The class seems to never be created and only used as type.

Bug: none
Change-Id: I046e222e6c693f203f1d0288a8d1d332f20a4d1e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6152578
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
This commit is contained in:
Nikolay Vitkov
2025-01-08 05:20:52 -08:00
committed by Devtools-frontend LUCI CQ
parent c430a4a350
commit 822382beba
1 changed files with 21 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
front_end/entrypoints/heap_snapshot_worker/HeapSnapshot.ts
+21 -26
View File
@@ -735,7 +735,7 @@ const MIN_OBJECT_COUNT_PER_INTERFACE = 2;
export abstract class HeapSnapshot {
nodes: Platform.TypedArrayUtilities.BigUint32Array;
containmentEdges: Platform.TypedArrayUtilities.BigUint32Array;
readonly #metaNode: HeapSnapshotMetainfo;
readonly #metaNode: HeapSnapshotMetaInfo;
readonly #rawSamples: number[];
#samples: HeapSnapshotModel.HeapSnapshotModel.Samples|null;
strings: string[];
@@ -2724,34 +2724,29 @@ export abstract class HeapSnapshot {
}
}
class HeapSnapshotMetainfo {
location_fields: string[] = []; // eslint-disable-line @typescript-eslint/naming-convention
node_fields: string[] = []; // eslint-disable-line @typescript-eslint/naming-convention
node_types: string[][] = []; // eslint-disable-line @typescript-eslint/naming-convention
edge_fields: string[] = []; // eslint-disable-line @typescript-eslint/naming-convention
edge_types: string[][] = []; // eslint-disable-line @typescript-eslint/naming-convention
trace_function_info_fields: string[] = []; // eslint-disable-line @typescript-eslint/naming-convention
trace_node_fields: string[] = []; // eslint-disable-line @typescript-eslint/naming-convention
sample_fields: string[] = []; // eslint-disable-line @typescript-eslint/naming-convention
type_strings: {[key: string]: string} = {}; // eslint-disable-line @typescript-eslint/naming-convention
interface HeapSnapshotMetaInfo {
/* eslint-disable @typescript-eslint/naming-convention */
location_fields: string[];
node_fields: string[];
node_types: string[][];
edge_fields: string[];
edge_types: string[][];
trace_function_info_fields: string[];
trace_node_fields: string[];
sample_fields: string[];
type_strings: {[key: string]: string};
/* eslint-enable @typescript-eslint/naming-convention */
}
export class HeapSnapshotHeader {
export interface HeapSnapshotHeader {
/* eslint-disable @typescript-eslint/naming-convention */
title: string;
meta: HeapSnapshotMetainfo;
node_count: number; // eslint-disable-line @typescript-eslint/naming-convention
edge_count: number; // eslint-disable-line @typescript-eslint/naming-convention
trace_function_count: number; // eslint-disable-line @typescript-eslint/naming-convention
root_index: number; // eslint-disable-line @typescript-eslint/naming-convention
constructor() {
// New format.
this.title = '';
this.meta = new HeapSnapshotMetainfo();
this.node_count = 0;
this.edge_count = 0;
this.trace_function_count = 0;
this.root_index = 0;
}
meta: HeapSnapshotMetaInfo;
node_count: number;
edge_count: number;
trace_function_count: number;
root_index: number;
/* eslint-enable @typescript-eslint/naming-convention */
}
export abstract class HeapSnapshotItemProvider {