zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-30 18:03:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make closure aware of enums in CDP params

Browse Source 
Change-Id: Id9a05a9fdc6e2fbc15914a2bfb58469d7b7cc539
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2204105
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
This commit is contained in:
Jan Scheffler
2020-05-15 14:33:21 +00:00
committed by Commit Bot
parent 992b291d52
commit 97aa83941c
1 changed files with 22 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/build/generate_protocol_externs.py
+22 -5
View File
@@ -84,7 +84,11 @@ def generate_enum(name, json):
return "\n/** @enum {string} */\n%s = {\n%s\n};\n" % (name, (",\n".join(enum_members)))
def param_type(domain_name, param):
def param_type(domain_name, param, command=None):
if "enum" in param and command:
return "Protocol.%s.%sRequest%s" % (domain_name,
to_title_case(command["name"]),
to_title_case(param_name(param)))
if "type" in param:
if param["type"] == "array":
items = param["items"]
@@ -139,11 +143,19 @@ def generate_protocol_externs(output_path, file1, file2):
if "commands" in domain:
for command in domain["commands"]:
output_file.write("\n/**\n")
params = []
in_param_to_type = {}
out_param_to_type = {}
has_return_value = "returns" in command
if "parameters" in command:
for param in command["parameters"]:
if "enum" in param:
enum_name = param_type(domain_name, param, command)
output_file.write(generate_enum(enum_name, param))
output_file.write("\n/**\n")
if "parameters" in command:
# Only declare trailing optional parameters as optional in
# JSDoc annotations.
@@ -158,13 +170,18 @@ def generate_protocol_externs(output_path, file1, file2):
real_in_param_name = "opt_" + in_param_name if in_param_name in trailing_optional else in_param_name
params.append(real_in_param_name)
if "optional" in in_param:
in_param_to_type[in_param_name] = "(%s|undefined)" % param_type(domain_name, in_param)
in_param_to_type[
in_param_name] = "(%s|undefined)" % param_type(
domain_name, in_param)
annotation_suffix = "=" if in_param_name in trailing_optional else "|undefined"
else:
in_param_to_type[in_param_name] = param_type(domain_name, in_param)
in_param_to_type[in_param_name] = param_type(
domain_name, in_param)
annotation_suffix = ""
output_file.write(
" * @param {%s%s} %s\n" % (param_type(domain_name, in_param), annotation_suffix, real_in_param_name))
" * @param {%s%s} %s\n" %
(param_type(domain_name, in_param),
annotation_suffix, real_in_param_name))
returns = []
returns.append("?Protocol.Error")
if ("error" in command):