Add UMA for the Recorder panel

Backend CL: crrev.com/c/3268130
Bug: 1267792
Change-Id: I62857d299b9e6cd9da0ef369554508df23229053
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3268285
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
This commit is contained in:
Alex Rudenko
2021-11-10 07:44:13 +00:00
committed by Devtools-frontend LUCI CQ
parent 016cb977fc
commit e3c100e5f7
3 changed files with 80 additions and 0 deletions
@@ -369,4 +369,9 @@ export enum EnumeratedHistogram {
Language = 'DevTools.Language',
ConsoleShowsCorsErrors = 'DevTools.ConsoleShowsCorsErrors',
SyncSetting = 'DevTools.SyncSetting',
RecordingEdited = 'DevTools.RecordingEdited',
RecordingExported = 'DevTools.RecordingExported',
RecordingReplayFinished = 'DevTools.RecordingReplayFinished',
RecordingReplayStarted = 'DevTools.RecordingReplayStarted',
RecordingToggled = 'DevTools.RecordingToggled',
}
+70
View File
@@ -261,6 +261,31 @@ export class UserMetrics {
InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.SyncSetting, settingValue, size);
});
}
recordingToggled(value: RecordingToggled): void {
const size = Object.keys(RecordingToggled).length + 1;
InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.RecordingToggled, value, size);
}
recordingReplayFinished(value: RecordingReplayFinished): void {
const size = Object.keys(RecordingReplayFinished).length + 1;
InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.RecordingReplayFinished, value, size);
}
recordingReplayStarted(value: RecordingReplayStarted): void {
const size = Object.keys(RecordingReplayStarted).length + 1;
InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.RecordingReplayStarted, value, size);
}
recordingEdited(value: RecordingEdited): void {
const size = Object.keys(RecordingEdited).length + 1;
InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.RecordingEdited, value, size);
}
recordingExported(value: RecordingExported): void {
const size = Object.keys(RecordingExported).length + 1;
InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.RecordingExported, value, size);
}
}
// Codes below are used to collect UMA histograms in the Chromium port.
@@ -827,3 +852,48 @@ export enum SyncSetting {
DevToolsSyncSettingDisabled = 3,
DevToolsSyncSettingEnabled = 4,
}
// TODO(crbug.com/1167717): Make this a const enum again
// eslint-disable-next-line rulesdir/const_enum
export enum RecordingToggled {
RecordingStarted = 1,
RecordingFinished = 2,
}
// TODO(crbug.com/1167717): Make this a const enum again
// eslint-disable-next-line rulesdir/const_enum
export enum RecordingReplayFinished {
Success = 1,
TimeoutErrorSelectors = 2,
TimeoutErrorTarget = 3,
OtherError = 4,
}
// TODO(crbug.com/1167717): Make this a const enum again
// eslint-disable-next-line rulesdir/const_enum
export enum RecordingReplayStarted {
ReplayOnly = 1,
ReplayWithPerformanceTracing = 2,
}
// TODO(crbug.com/1167717): Make this a const enum again
// eslint-disable-next-line rulesdir/const_enum
export enum RecordingEdited {
SelectorPickerUsed = 1,
StepAdded = 2,
StepRemoved = 3,
SelectorAdded = 4,
SelectorRemoved = 5,
SelectorPartAdded = 6,
SelectorPartEdited = 7,
SelectorPartRemoved = 8,
TypeChanged = 9,
OtherEditing = 10,
}
// TODO(crbug.com/1167717): Make this a const enum again
// eslint-disable-next-line rulesdir/const_enum
export enum RecordingExported {
ToPuppeteer = 1,
ToJSON = 2,
}
+5
View File
@@ -396,6 +396,11 @@
LinearMemoryInspectorTarget: 'DevTools.LinearMemoryInspector.Target',
Language: 'DevTools.Language',
ConsoleShowsCorsErrors: 'DevTools.ConsoleShowsCorsErrors',
RecordingEdited: 'DevTools.RecordingEdited',
RecordingExported: 'DevTools.RecordingExported',
RecordingReplayFinished: 'DevTools.RecordingReplayFinished',
RecordingReplayStarted: 'DevTools.RecordingReplayStarted',
RecordingToggled: 'DevTools.RecordingToggled',
};
/**